Skip to content

Ability to Join Classroom Added #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 19, 2023
Merged

Ability to Join Classroom Added #10

merged 2 commits into from
Feb 19, 2023

Conversation

@Om-Gujarathi
Copy link
Collaborator

@Om-Gujarathi Om-Gujarathi commented Feb 17, 2023

No description provided.

@Om-Gujarathi Om-Gujarathi mentioned this pull request Feb 17, 2023
Closed
shatanikmahanty
shatanikmahanty requested changes Feb 18, 2023
View reviewed changes
Copy link
Member

@shatanikmahanty shatanikmahanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refrain from using hardcoded values for sdk version in build.gradle. Use them through configured values in local.properties file

@shatanikmahanty shatanikmahanty linked an issue Feb 18, 2023 that may be closed by this pull request
Ability to join classroom #9
Closed
@shatanikmahanty
Copy link
Member

shatanikmahanty commented Feb 18, 2023 •
edited
Loading 

sdk.dir=D:\\Android\\SDK
flutter.sdk=D:\\flutter
flutter.buildMode=debug
flutter.versionName=1.0.0
flutter.versionCode=1
flutter.minSdkVersion=24
flutter.targetSdkVersion=33
flutter.compileSdkVersion=33

This is how it should look like. Use the given configuration, but make sure to replace it with your sdk paths. Also, make sure not to add the file in your commit as it contains user dependent paths.

@Om-Gujarathi
Copy link
Collaborator Author

Om-Gujarathi commented Feb 19, 2023

Please refrain from using hardcoded values for sdk version in build.gradle. Use them through configured values in local.properties file

Yes I have made the requested changes.

shatanikmahanty
shatanikmahanty approved these changes Feb 19, 2023
View reviewed changes
Copy link
Member

@shatanikmahanty shatanikmahanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Ready to merge 🚀

@shatanikmahanty shatanikmahanty merged commit 6e5ba4d into main Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shatanikmahanty shatanikmahanty shatanikmahanty approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Ability to join classroom

3 participants

@Om-Gujarathi @shatanikmahanty