Skip to content

Commit ded996e

Browse files
BunsDevclaude
andcommitted
fix(daemon): make Duration import unconditional for Windows build
Follow-up to f8a191d (#50 fix). The `check_reachability(timeout: Duration)` method signature uses `Duration` unconditionally, but `use std::time::Duration` was gated behind `#[cfg(unix)]`. macOS/Linux builds (where I ran cargo check) had the import in scope via the unix-only body, but the Windows target — where the non-unix arm renders `let _ = timeout` and never touches `Duration` — failed compile because the signature still references the type. Drop the cfg gate on the Duration import. Unix and Windows now share the same import line. (`UnixStream`, `Read`, `Write`, and the `coven_home` helper stay gated — they're only used inside the unix arms.) The v0.0.17 Release workflow's Windows build was the only one that failed on this; macOS/Linux builds were green. Re-dispatching now. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 0c7ad4b commit ded996e

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

src-rust/crates/core/src/coven_daemon.rs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,9 @@ use std::io::{Read, Write};
1111
use std::os::unix::net::UnixStream;
1212
#[cfg(unix)]
1313
use std::path::PathBuf;
14-
#[cfg(unix)]
14+
// `Duration` appears in the public `check_reachability(timeout)` signature,
15+
// so its import can't be gated on `cfg(unix)` even though the only real
16+
// implementation lives there.
1517
use std::time::Duration;
1618

1719
use serde::{Deserialize, Serialize};

0 commit comments

Comments
 (0)