feat: Implement user confirmation mode, request confirmation when running bash/python code in this mode#2774
Conversation
There was a problem hiding this comment.
Thanks a ton for this contribution!!
Backend part LGTM 👍 ! Can anyone from the front side take a look?
plus: right now, confirmation mode has to be set at the beginning of the conv, and there's no way to switch them on and off during an interaction session. I guess the next step of improvement would be to support "switch them on/off on the fly" - let's open an issue to track this once this PR is merged :D
|
LGTM! @adrgs , could you please fix the lint and the failed unit tests? |
amanape
left a comment
There was a problem hiding this comment.
Also, don't forget to lint your code in order to merge changes!
|
Thanks everyone for the great feedback! I've added a new commit with the changes. Let me know if there is anything else to be done. Thank you |
|
I think CmdKillAction no longer exists, merge issue? |
amanape
left a comment
There was a problem hiding this comment.
Hey! Sorry for the delay. It seems your package-lock.json and package.json are not in sync. Try removing the package-lock.json and running npm install again.
1d836f9 to
0bff2fa
Compare
|
Added, sorry for that. |
|
It looks that one of the Python tests are failing. I'm not sure if it is due to flakiness or due to the changes you have introduced. @enyst Could you confirm if it is due to the change they made to |
|
I guess it should be flakiness. Rerun the test to see the result. |
|
Added missing is_confirmed in test outputs |
amanape
left a comment
There was a problem hiding this comment.
Thanks a lot for this cool feature! Awesome stuff
What is the problem that this fixes or functionality that this introduces? Does it fix any open issues?
Implements #2308 enhancement
Give a brief summary of what the PR does, explaining any non-trivial design decisions
AWAITING_USER_CONFIRMATION,ACTION_CONFIRMED,ACTION_REJECTEDOther references
Screenshots: