-
Notifications
You must be signed in to change notification settings - Fork 9
V1.4 release #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V1.4 release #58
Conversation
|
Perfect, all issues considered. Ready to merge from my side. |
@Ludee, @christian-rli Side note on the release format: I would stick with "three digit" release number format, i.e. v1.5.0 in case it should be v1.5. This reference guide for semantic versioning could also help answer your question. |
|
I would go with either using 1.4.0 or, based on the recommendations in the reference guide linked by @Bachibouzouk , 2.0.0. It's tricky. My reason for both options is, that there was no real 1.4.0 before. I realize that there are strings compatible with an almost complete version 1.4.0. But 1.4.0 was never declared complete and it's not clear that they conform to the same version of the string (I would assume they don't). There would be a weird gap of versions, because what is 1.4.0 then? Why isn't there a function to convert from it? It's been codenamed 1.4 all along would just need to be declared "done" now. 2.0.0, could make sense, because if we create a new version number, this would reflect not being downwards-compatible to 1.3.0. |
|
I would favour: All unofficial versions were labelled "1.4" and can be updated easily. |
Clever! Let's just stick with |
|
Final changes are added to all three files! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked and Liked!
Closes #22 #32 #54 #57