Skip to content

Conversation

@christian-rli
Copy link
Contributor

Closes #22 #32 #54 #57

@christian-rli christian-rli requested a review from Ludee July 4, 2019 15:09
@Ludee Ludee added the metadata OEP metadata label Jul 4, 2019
@Ludee Ludee added this to the Metadata release v1.4 milestone Jul 4, 2019
@Ludee
Copy link
Member

Ludee commented Jul 4, 2019

Perfect, all issues considered. Ready to merge from my side.
We decided to gice a new version number, since there are multiple version of v1.4 now.
So this one would be v1.4.1 or v1.5!?

@Bachibouzouk
Copy link
Contributor

Bachibouzouk commented Jul 8, 2019

So this one would be v1.4.1 or v1.5!?

@Ludee, @christian-rli Side note on the release format: I would stick with "three digit" release number format, i.e. v1.5.0 in case it should be v1.5. This reference guide for semantic versioning could also help answer your question.

@christian-rli
Copy link
Contributor Author

christian-rli commented Jul 8, 2019

I would go with either using 1.4.0 or, based on the recommendations in the reference guide linked by @Bachibouzouk , 2.0.0. It's tricky. My reason for both options is, that there was no real 1.4.0 before.

I realize that there are strings compatible with an almost complete version 1.4.0. But 1.4.0 was never declared complete and it's not clear that they conform to the same version of the string (I would assume they don't). There would be a weird gap of versions, because what is 1.4.0 then? Why isn't there a function to convert from it? It's been codenamed 1.4 all along would just need to be declared "done" now.

2.0.0, could make sense, because if we create a new version number, this would reflect not being downwards-compatible to 1.3.0.

@Ludee
Copy link
Member

Ludee commented Jul 8, 2019

I would favour:
"metadataVersion": "OEP-1.4.0"

All unofficial versions were labelled "1.4" and can be updated easily.

@christian-rli
Copy link
Contributor Author

I would favour:
"metadataVersion": "OEP-1.4.0"

All unofficial versions were labelled "1.4"

Clever! Let's just stick with "metadataVersion": "OEP-1.4.0" then.

@Ludee
Copy link
Member

Ludee commented Jul 9, 2019

Final changes are added to all three files!

Copy link
Member

@Ludee Ludee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked and Liked!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

metadata OEP metadata

Projects

None yet

Development

Successfully merging this pull request may close these issues.

timestamps

4 participants