Headers overwrite #1219
Merged
Headers overwrite #1219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
velo
added
ready to merge
Member
|
Content type is not a multi-value header according to the spec. Are you sure you don’t mean Accept here? |
Member
Author
Exactly, but feign was adding multiple values on the Content-Type request.
No, content type. |
velo
added a commit
that referenced
this pull request
Oct 7, 2024
* Add unit test illustrating #1217 * Make sure content-type is limited to a single value Co-authored-by: Pierre de Soyres <pierre.de-soyres@eptica.com>
velo
added a commit
that referenced
this pull request
Oct 8, 2024
* Add unit test illustrating #1217 * Make sure content-type is limited to a single value Co-authored-by: Pierre de Soyres <pierre.de-soyres@eptica.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1217
Specially when using contracts, there is more than one way to set some headers.
Content-Typeseems to be the most special one, were client sends one.This change will guarantee that only one value for this header will survive.
@kdavisk6 do you think there is any situation feign would wan't to send more than one Content-Type header?