Skip to content

JacksonEncoder avoids intermediate String request body #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
velo merged 2 commits into from
Jun 24, 2019
Merged

JacksonEncoder avoids intermediate String request body #989

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e13e14
JacksonEncoder avoids intermediate String request body
schlosna Jun 18, 2019
080fa92
Use Util.UTF_8
schlosna Jun 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion jackson/src/main/java/feign/jackson/JacksonEncoder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
import feign.RequestTemplate;
import feign.codec.EncodeException;
import feign.codec.Encoder;
import feign.Util;

public class JacksonEncoder implements Encoder {

Expand All @@ -48,7 +49,7 @@ public JacksonEncoder(ObjectMapper mapper) {
public void encode(Object object, Type bodyType, RequestTemplate template) {
try {
JavaType javaType = mapper.getTypeFactory().constructType(bodyType);
template.body(mapper.writerFor(javaType).writeValueAsString(object));
template.body(mapper.writerFor(javaType).writeValueAsBytes(object), Util.UTF_8);
} catch (JsonProcessingException e) {
throw new EncodeException(e.getMessage(), e);
}
Expand Down