Does a new version get created on every manual run?

[taylordowns2000]

Possible bug here. Does a new workflow version get created on every manual run in the new collaborative editor?

🎯 Goal: It shouldn't! A new version should only be created if the workflow changed.

Placeholder

@lmac-1 and I have just detected something where the version number increases on every run (even if no changes are made)

Lucy [Today at 2:46 PM] I'm wondering if it's related to my PR from before which was touching all of that (clicking "latest" at the top and the warning message) #3941

Lucy 1 hour ago I just had a little look .. I don't think that the PR I linked is what broke things, but it does draw attention to the underlying bug.

When you run a workflow without making any changes, the version number still increments. Then, when you view that run, the UI shows the “old version” warning because the run’s version no longer matches the version in the header. That’s the unexpected behaviour.

Stu Corbishley 44 minutes ago The strange thing is, that only the server increments the number. The manual run function/behaviour on the backend is the same as it always was afaik

Lucy Yeah and I don't remember seeing version numbers going so high before.. strange

Lucy Extra context: The version number doesn't appear to increase when it runs automatically. Seems to only happen when manually kicking off a run from collab editor. For example - if the run runs via cron job, that doesn't increase version number, but if i manually click run from collab editor it does.

Taylor Downs Kicking off a run definitely saves and runs the workflow. The question is if the save event is sent, and there are no changes, does it still increment the version?

[lmac-1]

What I mean by "automatically" in that final comment is that if you have a workflow triggered by a cron job, this doesn't increase the version number when it runs.

[lmac-1]

Two other bugs:

1. If you save the workflow without making any changes, it creates a new version Saving a workflow in collaborative editor without making any changes creates a new version #4025
2. If a save creates a new version, the version dropdown doesn't update unless you refresh the page Saving in collaborative editor should update the version number in VersionDropdown without refreshing #4024

I know they are all probably related, but good to keep track of what's going on so we can make sure we fix everything.

[lmac-1]

Sorry @stuartc I know this one was assigned to you but I was digging into things a bit and wanted to understand what was going on. I have debugged with Claude on it and fixed both #4021 (new version created after every manual run) and #4025 in #4029.

However, more details in the PR (particularly in "Additional notes for the reviewer" section) on how this PR should be taken with a grain of salt and checked by someone with more knowledge of the bigger picture of things. It's quite likely that Claude has oversimplified the fix and missed something.

[lmac-1]

Also should mention, #4029 is still a draft. It's breaking some tests but I've run out of time. Would appreciate if you could take a look and let me know if it's the right approach. Thanks