Skip to content

Conversation

@doc-han
Copy link
Contributor

@doc-han doc-han commented Nov 28, 2025

Description

This PR resolves an issue where save&run buttons were disabled after creating a new workflow

Closes #4071

Validation steps

  1. Go to create a new workflow
  2. Click the experimental icon(beaker) in the header to switch to the new editor
  3. You'll notice we don't support templates there yet. Now use the import and then import some workflow via yaml. (example yaml provided below)
  4. After clicking create, are your run & save buttons enabled? Are you able to perform any action as usual? If yes then we're good

Additional notes for the reviewer

  1. (Is there anything else the reviewer should know or look out for?)

AI Usage

Please disclose how you've used AI in this work (it's cool, we just want to know!):

  • Code generation (copilot but not intellisense)
  • Learning or fact checking
  • Strategy / design
  • Optimisation / refactoring
  • Translation / spellchecking / doc gen
  • Other
  • I have not used AI

You can read more details in our Responsible AI Policy

Pre-submission checklist

  • I have performed a self-review of my code.
  • I have implemented and tested all related authorization policies. (e.g., :owner, :admin, :editor, :viewer)
  • I have updated the changelog.
  • I have ticked a box in "AI usage" in this PR

@doc-han doc-han linked an issue Nov 28, 2025 that may be closed by this pull request
@github-project-automation github-project-automation bot moved this to New Issues in v2 Nov 28, 2025
@doc-han doc-han marked this pull request as ready for review November 28, 2025 16:39
@codecov
Copy link

codecov bot commented Nov 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.79%. Comparing base (fe34e9c) to head (db49212).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4084      +/-   ##
==========================================
+ Coverage   88.78%   88.79%   +0.01%     
==========================================
  Files         422      422              
  Lines       19178    19179       +1     
==========================================
+ Hits        17027    17030       +3     
+ Misses       2151     2149       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@doc-han doc-han requested a review from stuartc November 28, 2025 17:17
Copy link
Contributor

@elias-ba elias-ba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @doc-han nice one. The fix is great. I could actually approve but I would love to draw your attention to the comments I left in my review. Also maybe confirm with @taylordowns2000 if we want to enable the 'Run' button during the creation mode. I could run my workflow before even saving it. The Run saved the workflow then ran but as a regular user that surprised me because I was expecting the button to just run. And after the run, I was directly in edit mode.

Image

@github-project-automation github-project-automation bot moved this from New Issues to In review in v2 Nov 30, 2025
@doc-han
Copy link
Contributor Author

doc-han commented Dec 1, 2025

Hey @doc-han nice one. The fix is great. I could actually approve but I would love to draw your attention to the comments I left in my review. Also maybe confirm with @taylordowns2000 if we want to enable the 'Run' button during the creation mode. I could run my workflow before even saving it. The Run saved the workflow then ran but as a regular user that surprised me because I was expecting the button to just run. And after the run, I was directly in edit mode.

Image

Resolved this too.
Made the buttons on the right of the header not accessible at this point in time

@doc-han doc-han requested a review from elias-ba December 1, 2025 10:05
@taylordowns2000
Copy link
Member

@theroinaochieng , is this still relevant after #4087 ?

@stuartc
Copy link
Member

stuartc commented Dec 2, 2025

@taylordowns2000 you might be right, I'm going to review the other PR and circle back.

Copy link
Member

@stuartc stuartc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the changes to the left-panel and the WorkflowEditor, really responsible css changes - I still need to reconcile the latest_snapshot_lock_version and isNewWorkflow logic against the other PR mentioned. So hang on for a bit, but these CSS changes must get into main.


return (
<div
className={`absolute inset-y-0 left-0 w-1/3 transition-transform duration-300 ease-in-out z-10 ${
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😘

@stuartc stuartc merged commit 44fa909 into main Dec 3, 2025
6 checks passed
@stuartc stuartc deleted the 4071-save-and-run-button-disabled-for-users-with-access branch December 3, 2025 10:43
@github-project-automation github-project-automation bot moved this from In review to Done in v2 Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Save and Run Button Disabled for Users with Access

5 participants