-
Notifications
You must be signed in to change notification settings - Fork 61
fix: save&run disabled after new workflow save #4084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: save&run disabled after new workflow save #4084
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4084 +/- ##
==========================================
+ Coverage 88.78% 88.79% +0.01%
==========================================
Files 422 422
Lines 19178 19179 +1
==========================================
+ Hits 17027 17030 +3
+ Misses 2151 2149 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
elias-ba
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @doc-han nice one. The fix is great. I could actually approve but I would love to draw your attention to the comments I left in my review. Also maybe confirm with @taylordowns2000 if we want to enable the 'Run' button during the creation mode. I could run my workflow before even saving it. The Run saved the workflow then ran but as a regular user that surprised me because I was expecting the button to just run. And after the run, I was directly in edit mode.
Resolved this too. |
|
@theroinaochieng , is this still relevant after #4087 ? |
|
@taylordowns2000 you might be right, I'm going to review the other PR and circle back. |
stuartc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like the changes to the left-panel and the WorkflowEditor, really responsible css changes - I still need to reconcile the latest_snapshot_lock_version and isNewWorkflow logic against the other PR mentioned. So hang on for a bit, but these CSS changes must get into main.
|
|
||
| return ( | ||
| <div | ||
| className={`absolute inset-y-0 left-0 w-1/3 transition-transform duration-300 ease-in-out z-10 ${ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😘
…ton-disabled-for-users-with-access

Description
This PR resolves an issue where save&run buttons were disabled after creating a new workflow
Closes #4071
Validation steps
Additional notes for the reviewer
AI Usage
Please disclose how you've used AI in this work (it's cool, we just want to know!):
You can read more details in our Responsible AI Policy
Pre-submission checklist
:owner,:admin,:editor,:viewer)