- 
                Notifications
    
You must be signed in to change notification settings  - Fork 58
 
Improve Docker management and bootstrap script with comprehensive refactoring #3589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    Updated postgres version in docker-compose.yml to 15.12
Automates updating Dockerfile ARG versions from .tool-versions file. Supports dry-run mode with side-by-side diffs, Debian version discovery via Docker Hub API, and atomic updates with rollback on failure. Usage: ./bin/update-images [update|--update-debian|--dry-run|show-debian-images]
          Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@            Coverage Diff             @@
##             main    #3589      +/-   ##
==========================================
- Coverage   89.57%   89.56%   -0.01%     
==========================================
  Files         401      401              
  Lines       16472    16472              
==========================================
- Hits        14754    14753       -1     
- Misses       1718     1719       +1     ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
  | 
    
- Remove caching and cleanup steps (no longer needed) - Use NodeSource repository setup script for Node.js installation - Install specific Node.js version matching Dockerfile approach
Extract major version using shell variable instead of inline pipe to avoid CircleCI parameter parsing errors.
- Add environment fact gathering phase - Separate dependency checking from installation strategy - Implement batch homebrew package installation - Add Rust dependency checking preferring existing install over Homebrew - Improve error handling with better status reporting - Show complete dependency overview before any installations - Use modern bash practices (set -euo pipefail, functions, arrays)
      
        
      
      
  
    9 tasks
  
819abda    to
    dea8ab8      
    Compare
  
    
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Description
This PR improves Docker build management and development environment setup scripts with comprehensive refactoring.
Changes:
Docker & Build Management:
bin/update-imagesscript that automates updating Dockerfile ARG versions from .tool-versions fileBootstrap Script Refactoring:
bin/bootstrapwith modern bash practices and better UXset -euo pipefail, functions, associative arraysValidation steps
Docker Management:
./bin/update-images --helpto see available commands./bin/update-images --dry-runto preview changes without applying themBootstrap Script:
./bin/bootstrapto test the improved dependency managementAdditional notes for the reviewer
AI Usage
Pre-submission checklist
:owner,:admin,:editor,:viewer)