Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,13 @@ and this project adheres to

### Fixed

## [v2.14.8-pre1] - 2025-10-01

### Fixed

- Send back `null` if a requested dataclip has been wiped
[PR#3652](https://github.com/OpenFn/lightning/pull/3652)

## [v2.14.8-pre] - 2025-10-01

### Fixed
Expand Down
6 changes: 4 additions & 2 deletions lib/lightning/dataclip_scrubber.ex
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,12 @@ defmodule Lightning.DataclipScrubber do
alias Lightning.Scrubber

@spec scrub_dataclip_body!(%{
body: String.t(),
body: String.t() | nil,
type: atom(),
id: Ecto.UUID.t()
}) :: String.t()
}) :: String.t() | nil
def scrub_dataclip_body!(%{body: nil}), do: nil

def scrub_dataclip_body!(%{body: body} = dataclip) when is_binary(body) do
if dataclip.type == :step_result do
step_query = from s in Step, where: s.output_dataclip_id == ^dataclip.id
Expand Down
2 changes: 1 addition & 1 deletion lib/lightning_web/controllers/dataclip_controller.ex
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ defmodule LightningWeb.DataclipController do
|> put_resp_header("vary", "Accept-Encoding, Cookie")
|> put_resp_header("cache-control", "private, max-age=#{@max_age}")
|> put_resp_header("last-modified", to_rfc1123!(dataclip.updated_at))
|> send_resp(200, body)
|> send_resp(200, body || "null")
end

defp dataclip_is_modified?(dataclip, last_modified) do
Expand Down
2 changes: 1 addition & 1 deletion mix.exs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ defmodule Lightning.MixProject do
def project do
[
app: :lightning,
version: "2.14.8-pre",
version: "2.14.8-pre1",
elixir: "~> 1.18",
elixirc_paths: elixirc_paths(Mix.env()),
elixirc_options: [
Expand Down