-
Notifications
You must be signed in to change notification settings - Fork 58
Updated GovStack API #3786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated GovStack API #3786
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3786 +/- ##
==========================================
- Coverage 88.58% 88.51% -0.07%
==========================================
Files 414 420 +6
Lines 17943 18116 +173
==========================================
+ Hits 15895 16036 +141
- Misses 2048 2080 +32 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@taylordowns2000 this looks great! I'm however worried that we ignore invalid timestamp values, was that part of the spec? I would prefer to have it return an error if the params are invalid.
Also could you add a few more tests for the other controllers?
Description
This PR adds the missing methods for an updated GovStack-compliant API, closes #1656
Validation steps
AI Usage
Please disclose how you've used AI in this work (it's cool, we just want to know!):
You can read more details in our Responsible AI Policy
Pre-submission checklist
:owner,:admin,:editor,:viewer)