feat: add wildcard theme resolution to build and clean commands#150
Merged
feat: add wildcard theme resolution to build and clean commands#150
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for wildcard theme codes (e.g., Vendor/*) to the theme build/clean CLI commands by centralizing wildcard expansion in the shared AbstractCommand base class.
Changes:
- Add
AbstractCommand::resolveWildcardThemes()to expand wildcard theme arguments usingThemeList. - Apply wildcard resolution in
mageforge:theme:buildandmageforge:theme:clean. - Refine build summary output messaging when no themes were built successfully.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/Console/Command/Theme/CleanCommand.php |
Resolves wildcard theme arguments before interactive selection / execution. |
src/Console/Command/Theme/BuildCommand.php |
Resolves wildcard theme arguments early; improves build summary messaging. |
src/Console/Command/AbstractCommand.php |
Introduces shared wildcard expansion helper using ThemeList. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds wildcard theme argument resolution (e.g., Vendor/*) to the theme build and clean CLI commands by introducing a shared helper in AbstractCommand.
Changes:
- Added
AbstractCommand::resolveWildcardThemes()to expand wildcard theme codes to installed theme codes. - Updated
mageforge:theme:buildandmageforge:theme:cleanto apply wildcard resolution to providedthemeCodes. - Improved
BuildCommand’s build summary messaging to better reflect whether any themes were built.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/Console/Command/Theme/CleanCommand.php | Applies wildcard expansion to themeCodes during theme selection resolution. |
| src/Console/Command/Theme/BuildCommand.php | Applies wildcard expansion early in execution; adjusts build summary output based on success count. |
| src/Console/Command/AbstractCommand.php | Introduces shared wildcard expansion helper using ThemeList. |
github-actions
bot
added
the
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.