Skip to content

fix: enhance cache cleaning in InspectorCommand to include layout and…#195

Merged
dermatz merged 3 commits into
mainfrom
fix/InspectorCommandCacheClean
Jun 3, 2026
Merged

fix: enhance cache cleaning in InspectorCommand to include layout and…#195
dermatz merged 3 commits into
mainfrom
fix/InspectorCommandCacheClean

Conversation

@dermatz
Copy link
Copy Markdown
Member

@dermatz dermatz commented Jun 3, 2026

This pull request updates the cache cleaning logic in the InspectorCommand to clear additional cache types, ensuring a more thorough cache reset when the command is executed.

Cache management improvements:

  • Expanded the cache types cleared in the cleanCache method from only config to also include layout, full_page, and block_html, and updated the output message accordingly in InspectorCommand.php.… full page caches

Copilot AI review requested due to automatic review settings June 3, 2026 21:41
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the MageForge mageforge:theme:inspector CLI command’s cache reset behaviour so enabling/disabling the frontend inspector more reliably takes effect by clearing additional Magento cache types.

Changes:

  • Expanded InspectorCommand::cleanCache() to clean config, layout, full_page, and block_html caches (instead of only config).
  • Updated the command output message to reflect the broader cache cleaning.

Comment thread src/Console/Command/Dev/InspectorCommand.php
Comment thread src/Console/Command/Dev/InspectorCommand.php Outdated
Copilot AI review requested due to automatic review settings June 3, 2026 21:46
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@dermatz dermatz merged commit f8de418 into main Jun 3, 2026
13 checks passed
@dermatz dermatz deleted the fix/InspectorCommandCacheClean branch June 3, 2026 21:54
@github-actions github-actions Bot mentioned this pull request Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants