feat: Adds a more user friendly message when the exectuable isn't found #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwiebe
reviewed
Aug 29, 2025
moorec-aws
approved these changes
Sep 11, 2025
epmog
reviewed
Sep 11, 2025
Comment on lines
+82
to
+85
| if exe_path is not None: | ||
| raise FileNotFoundError( | ||
| f"Could not find executable at: {exe_path} using alias {executable}\n" | ||
| f"Error:{fnf_error}" |
Contributor
There was a problem hiding this comment.
For my own curiosity, how does a user end up in this situation?
Contributor
Author
There was a problem hiding this comment.
If an alias gets broken this'll happen. I can't imagine this really ever gets run, but if it does we'd be happy to have it. :)
mwiebe
approved these changes
Sep 16, 2025
…tor's executable on the system PATH. Signed-off-by: Justin Blagden <jblagden@users.noreply.github.com>
…sage. Signed-off-by: Justin Blagden <jblagden@users.noreply.github.com>
Signed-off-by: Justin Blagden <jblagden@users.noreply.github.com>
epmog
force-pushed
the
improve_subprocess_exectuable_message
branch
from
e850f81 to
3d78c02
Compare
|
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #113
What was the problem/requirement? (What/Why)
When the adaptor fails to find the set executable, it'll fail with [WinError 2] The system cannot find the file specified, which without any context doesn't set users up to sort the issue out.
What was the solution? (How)
This change adds user friendly messages about what's failing and possible reasons why.
What is the impact of this change?
Users will see more logging when the adaptor fails to find the executable it has been set to run.
How was this change tested?
Currently a gap in this PR - I'm not sure where to start testing if a file does or does not exist and modifying the environment within a test.
See DEVELOPMENT.md for information on running tests.
Was this change documented?
Yes, to failures on TestIntegrationClientInterface, TestIntegrationLoggingSubprocess, and TestDaemonMode:
FAILED test/openjd/adaptor_runtime_client/integ/test_integration_client_interface.py::TestIntegrationClientInterface::test_graceful_shutdown - AssertionError: assert 'Received SIGTERM signal.' in ''
FAILED test/openjd/adaptor_runtime/integ/process/test_integration_logging_subprocess.py::TestIntegrationLoggingSubprocess::test_stop_process[StopProcessWhenSIGTERMFails] - Failed: Timeout >5.0s
FAILED test/openjd/adaptor_runtime/integ/background/test_background_mode.py::TestDaemonMode::test_shutdown - psutil.TimeoutExpired: timeout after 1 seconds (pid=11312)
I'm working in the Windows subsystem for Linux which might be the cause of the failing timeouts but I'm not sure about the SIGTERM issue. I'm hoping the github runners shed a little light on what's happening.
Yes.
Is this a breaking change?
No.
Does this change impact security?
No.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.