Skip to content

Conversation

@epmog
Copy link
Contributor

@epmog epmog commented Jun 4, 2025

What was the problem/requirement? (What/Why)

When running pip install with an sdist (compressed or uncompressed) you get:

OSError: Build script does not exist: hatch_version_hook.py

What was the solution? (How)

Instead of packaging only the package for sdist, we also now include the custom script

What is the impact of this change?

buildable/installable sdist

How was this change tested?

hatch clean && hatch build && pip install --force-reinstall dist/openjd*.tar.gz

Was this change documented?

N/A

Is this a breaking change?

N/A

Does this change impact security?

N/A


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Signed-off-by: Morgan Epp <60796713+epmog@users.noreply.github.com>
@epmog epmog requested a review from a team as a code owner June 4, 2025 19:14
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 4, 2025

@epmog epmog merged commit ed30b7f into OpenJobDescription:mainline Jun 4, 2025
19 checks passed
@epmog epmog deleted the fix_sdist branch June 4, 2025 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants