feat: Exposing ExtensionName publicy #200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brian Axelson <86568017+baxeaz@users.noreply.github.com>
|
crowecawcaw
approved these changes
Jun 6, 2025
jusiskin
requested changes
Jun 6, 2025
Contributor
jusiskin
left a comment
jusiskin
left a comment
There was a problem hiding this comment.
This should be a feat: and not a fix:, right?
baxeaz
changed the title
Contributor
Author
Hmm I guess? Updated! |
jusiskin
approved these changes
Jun 6, 2025
mwiebe
approved these changes
Jun 6, 2025
This was referenced Jun 9, 2025
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
We want to expose the ExtensionName publicly for consumers of openjd-model to use
What was the solution? (How)
Expose it
What is the impact of this change?
Can access the enum
How was this change tested?
hatch run test, used in changes I'm making to the Unreal integration
Was this change documented?
No
Is this a breaking change?
No
Does this change impact security?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.