feat: Attempting to load use CSafeLoader for faster YAML parsing wher… #219
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



What was the problem/requirement? (What/Why)
Our yaml parser was far slower than our JSON parser which prevented certain checks we'd like to do at job creation time in some cases and generally caused our create job API to run slower than we'd like.
What was the solution? (How)
Try to use the yaml CSafeLoader where available. Create benchmarking tests to note the difference.
What is the impact of this change?
How was this change tested?
All unit tests pass
Benchmarking test created which passes and shows above performance improvements
Was this change documented?
Yes
Is this a breaking change?
No
Does this change impact security?
No - the CSafeLoader is a C implementation of the safe loader we were using previously - https://pyyaml.org/wiki/PyYAMLDocumentation
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.