Added sensor ranges and units to RDM ModelCollector - #1275
Merged
Conversation
peternewman
requested changes
Jun 28, 2017
peternewman
left a comment
peternewman
left a comment
Member
There was a problem hiding this comment.
Just a few minor lint issues to fix please.
| 'normal_min':data['normal_min'], | ||
| 'normal_max':data['normal_max'], | ||
| 'unit':data['unit'], | ||
|
|
Member
There was a problem hiding this comment.
Can you drop the blank line please.
| 'description': data['name'], | ||
| 'type': data['type'], | ||
| 'supports_recording': data['supports_recording'], | ||
| 'range_min':data['range_min'], |
Member
There was a problem hiding this comment.
Can we have a space after the colon and before data please.
Author
|
Sorry about format. Fixed. |
peternewman
approved these changes
Jun 29, 2017
Member
|
Retrospective review if you fancy it @nomis52 . |
Member
|
On a side note @vanous I see you've got a lot more manufacturer specific PIDs listed in that file than we currently have: You should really add these to the system too, so people can use them to control the fixtures: |
peternewman
added a commit
to peternewman/rdm-app
that referenced
this pull request
Jul 14, 2017
From the snapshot here: OpenLightingProject/ola#1275
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example of collected data with these ranges in: robin_dl7s_profile@robe.txt
thank you
Petr