fix(setting): handle delete of setting item with empty key (#2131)

Author: j2rong4cn

internal/bootstrap/data/setting.go

@@ -34,6 +34,13 @@ func initSettings() {
 	}
 	settingMap := map[string]*model.SettingItem{}
 	for _, v := range settings {
+		if v.Key == "" {
+			err := db.DeleteSettingItemByKey(v.Key)
+			if err != nil {
+				utils.Log.Errorf("failed delete setting with empty key: %+v", err)
+			}
+			continue
+		}
 		if !isActive(v.Key) && v.Flag != model.DEPRECATED {
 			v.Flag = model.DEPRECATED
 			err = op.SaveSettingItem(&v)

internal/db/settingitem.go

@@ -65,5 +65,5 @@ func SaveSettingItem(item *model.SettingItem) error {
 }
 
 func DeleteSettingItemByKey(key string) error {
-	return errors.WithStack(db.Delete(&model.SettingItem{Key: key}).Error)
+	return errors.WithStack(db.Where(fmt.Sprintf("%s = ?", columnName("key")), key).Delete(model.SettingItem{}).Error)
 }