Skip to content

Conversation

@grandsuri
Copy link
Contributor

No description provided.

@grandsuri grandsuri requested a review from a team as a code owner May 10, 2023 00:06
@velomatt
Copy link
Contributor

Please pull changes from master. This branch does not have up-to-date CI/CD.

@grandsuri
Copy link
Contributor Author

grandsuri commented May 10, 2023

FYI
The file dss_sdk/host/src/openmpdk/PDK/core/src/api/include/rdd_cl.h is split into two files dss_sdk/utils/include/rdd_cl_api.h and dss_sdk/utils/rdd_cl/rdd_cl.h. We need either the first file or the latter 2 files to compile client code.

Since the first file is in openmpdk repo, I just went with the 2 files in dss_sdk repo and added those 2 files to Makefile to copy into nkv-sdk-bin tar ball artifact.

velomatt
velomatt previously approved these changes May 11, 2023
Copy link
Contributor

@velomatt velomatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me. I've confirmed these artifacts now appear in include in the artifact subdirectory for nkv-sdk-bin

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@velomatt
Copy link
Contributor

Contents of host_out post-build:

bash-4.2$ find host_out/ -name "*rdd*"
host_out/lib/librdd_cl.so
host_out/utils/rdd_cl
host_out/utils/rdd_cl/CMakeFiles/rdd_cl.dir
host_out/utils/rdd_cl/CMakeFiles/rdd_cl.dir/rdd_cl.c.d
host_out/utils/rdd_cl/CMakeFiles/rdd_cl.dir/rdd_cl.c.o
host_out/include/rdd_cl_api.h
host_out/include/rdd_cl.h

Contents of nkv-sdk-bin tarball:

bash-4.2$ find nkv-sdk -name "*rdd*"
nkv-sdk/include/rdd_cl_api.h
nkv-sdk/include/rdd_cl.h
nkv-sdk/lib/librdd_cl.so
nkv-sdk/conf/nkv_config_rdd.json

Assuming this is the expected behavior, I approve

Copy link
Contributor

@velomatt velomatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - per my comments above

@grandsuri
Copy link
Contributor Author

Contents of host_out post-build:

bash-4.2$ find host_out/ -name "*rdd*"
host_out/lib/librdd_cl.so
host_out/utils/rdd_cl
host_out/utils/rdd_cl/CMakeFiles/rdd_cl.dir
host_out/utils/rdd_cl/CMakeFiles/rdd_cl.dir/rdd_cl.c.d
host_out/utils/rdd_cl/CMakeFiles/rdd_cl.dir/rdd_cl.c.o
host_out/include/rdd_cl_api.h
host_out/include/rdd_cl.h

Contents of nkv-sdk-bin tarball:

bash-4.2$ find nkv-sdk -name "*rdd*"
nkv-sdk/include/rdd_cl_api.h
nkv-sdk/include/rdd_cl.h
nkv-sdk/lib/librdd_cl.so
nkv-sdk/conf/nkv_config_rdd.json

Assuming this is the expected behavior, I approve

Yes

@grandsuri grandsuri merged commit 1e6f6ef into master May 12, 2023
@grandsuri grandsuri deleted the rdd_library branch May 12, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants