-
-
Notifications
You must be signed in to change notification settings - Fork 452
Unified admin buttons #4982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unified admin buttons #4982
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds CSS classes to admin buttons in both PHP backend code and Cypress test files to improve styling consistency and testability.
- Adds standardized CSS classes to admin buttons throughout the Magento admin interface
- Updates Cypress test configurations to include CSS class definitions for button testing
- Extends base button configurations with proper CSS class arrays
Reviewed Changes
Copilot reviewed 61 out of 61 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| cypress/support/openmage/backend/system/*.js | Updated test configurations to include CSS classes for admin buttons |
| cypress/support/openmage/backend/sales/*.js | Added CSS classes to sales-related button configurations |
| cypress/support/openmage/backend/promo/*.js | Updated promo button configurations with CSS classes |
| cypress/support/openmage/backend/newsletter/*.js | Added CSS classes to newsletter template buttons |
| cypress/support/openmage/backend/customer/*.js | Updated customer management button configurations |
| cypress/support/openmage/backend/cms/*.js | Added CSS classes to CMS button configurations |
| cypress/support/openmage/backend/catalog/*.js | Updated catalog management button configurations |
| cypress/support/openmage/_utils/*.js | Extended base test utilities with CSS class support and validation |
| app/code/core/Mage//Block/Adminhtml//*.php | Updated PHP admin blocks to include proper CSS classes on buttons |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 85 out of 85 changed files in this pull request and generated 4 comments.
Comments suppressed due to low confidence (1)
cypress/support/openmage/_utils/test.js:1
- The 'back' button is incorrectly assigned to saveAndContinue button. It should be assigned to the back button:
cy.openmage.test.backend.__base.__buttons.back.
/**
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 85 out of 85 changed files in this pull request and generated 4 comments.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@kiatng, @addison74 ...is it okay to change some button labels? |
|
|
Had two greens. Only fixed tests. |


Description (*)
save and continue buttonsin new PRIssues here ... cypress-screenshots