Skip to content

Conversation

@sreichel
Copy link
Contributor

@sreichel sreichel commented Oct 11, 2025

Description (*)

  • Unified button labels
    • most buttons were labeled "Save", or "Delete", a few others labeled e.g. "Save Page"
      • unified to short version, so all pages look same
  • Added additional CSS classes to admin buttons for better access.
    • "save and continue" button
    • "reset button"
    • ...
  • Added buttons
    • missing reset buttons
    • save and continue buttons in new PR
  • Updated cypress tests
    • validate buttons
    • test reset/back button
    • ...

Issues here ... cypress-screenshots

@github-actions github-actions bot added Component: Adminhtml Relates to Mage_Adminhtml Component: Widget Relates to Mage_Widget Component: Oauth Relates to Mage_Oauth Component: Api2 Relates to Mage_Api2 labels Oct 11, 2025
@sreichel sreichel changed the title Add correct CSS classes to admin buttons Add CSS classes to admin buttons Oct 11, 2025
@sreichel sreichel marked this pull request as ready for review October 11, 2025 20:56
Copilot AI review requested due to automatic review settings October 11, 2025 20:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds CSS classes to admin buttons in both PHP backend code and Cypress test files to improve styling consistency and testability.

  • Adds standardized CSS classes to admin buttons throughout the Magento admin interface
  • Updates Cypress test configurations to include CSS class definitions for button testing
  • Extends base button configurations with proper CSS class arrays

Reviewed Changes

Copilot reviewed 61 out of 61 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
cypress/support/openmage/backend/system/*.js Updated test configurations to include CSS classes for admin buttons
cypress/support/openmage/backend/sales/*.js Added CSS classes to sales-related button configurations
cypress/support/openmage/backend/promo/*.js Updated promo button configurations with CSS classes
cypress/support/openmage/backend/newsletter/*.js Added CSS classes to newsletter template buttons
cypress/support/openmage/backend/customer/*.js Updated customer management button configurations
cypress/support/openmage/backend/cms/*.js Added CSS classes to CMS button configurations
cypress/support/openmage/backend/catalog/*.js Updated catalog management button configurations
cypress/support/openmage/_utils/*.js Extended base test utilities with CSS class support and validation
app/code/core/Mage//Block/Adminhtml//*.php Updated PHP admin blocks to include proper CSS classes on buttons

@sreichel sreichel marked this pull request as draft October 13, 2025 01:20
@github-actions github-actions bot added Component: Catalog Relates to Mage_Catalog Template : admin Relates to admin template labels Oct 13, 2025
@sreichel sreichel requested a review from Copilot October 13, 2025 07:33
@sreichel sreichel changed the title Add CSS classes to admin buttons Unified admin buttons Oct 13, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 85 out of 85 changed files in this pull request and generated 4 comments.

Comments suppressed due to low confidence (1)

cypress/support/openmage/_utils/test.js:1

  • The 'back' button is incorrectly assigned to saveAndContinue button. It should be assigned to the back button: cy.openmage.test.backend.__base.__buttons.back.
/**

sreichel and others added 4 commits October 13, 2025 10:16
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@sreichel sreichel marked this pull request as ready for review October 13, 2025 11:26
@sreichel sreichel requested a review from Copilot October 13, 2025 11:26
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 85 out of 85 changed files in this pull request and generated 4 comments.

sreichel and others added 4 commits October 13, 2025 13:50
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@sreichel sreichel marked this pull request as draft October 13, 2025 21:38
@sreichel
Copy link
Contributor Author

@kiatng, @addison74 ...is it okay to change some button labels?

@sreichel sreichel marked this pull request as ready for review October 14, 2025 05:50
Hanmac
Hanmac previously approved these changes Oct 14, 2025
kiatng
kiatng previously approved these changes Oct 15, 2025
@sreichel sreichel dismissed stale reviews from kiatng and Hanmac via 5820999 October 15, 2025 04:03
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
48.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@sreichel
Copy link
Contributor Author

sreichel commented Oct 15, 2025

Had two greens. Only fixed tests.

@sreichel sreichel merged commit b3b4ed0 into OpenMage:main Oct 15, 2025
21 of 22 checks passed
@sreichel sreichel deleted the cypress/buttons branch October 15, 2025 04:19
@sreichel sreichel removed the request for review from addison74 October 15, 2025 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Adminhtml Relates to Mage_Adminhtml Component: Api2 Relates to Mage_Api2 Component: Catalog Relates to Mage_Catalog Component: Oauth Relates to Mage_Oauth Component: Widget Relates to Mage_Widget cypress enhancement Template : admin Relates to admin template

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants