`geadd` and `const` qualifiers

[david-cortes]

In the wiki for OpenBLAS extensions:
https://github.com/OpenMathLib/OpenBLAS/wiki/OpenBLAS-Extensions

It describes ?geadd as follows:

ATLAS-like matrix add B = αA+βB

But in the header for function geadd:

OpenBLAS/cblas.h

Line 412 in f10d47c

void cblas_dgeadd(OPENBLAS_CONST enum CBLAS_ORDER CORDER,OPENBLAS_CONST blasint crows, OPENBLAS_CONST blasint ccols, OPENBLAS_CONST double calpha, double *a, OPENBLAS_CONST blasint clda, OPENBLAS_CONST double cbeta,

The type for A is a regular pointer instead of a const pointer.

Other extensions such as ?omatcopy use const qualifiers in the pointers to data that they do not modify:

OpenBLAS/cblas.h

Line 394 in f10d47c

void cblas_domatcopy(OPENBLAS_CONST enum CBLAS_ORDER CORDER, OPENBLAS_CONST enum CBLAS_TRANSPOSE CTRANS, OPENBLAS_CONST blasint crows, OPENBLAS_CONST blasint ccols, OPENBLAS_CONST double calpha, OPENBLAS_CONST double *a,

Is ?geadd meant to have a const qualifier for A in the signature, or can it potentially modify the data that it gets passed?

[martin-frbg]

I do not think there is a code path that would modify the A array - on first glance this looks more like a simple oversight from the time when GEADD was added, almost ten years ago (PR #509).