Skip to content

Conversation

@marxin
Copy link
Contributor

@marxin marxin commented Feb 17, 2020

As described here: #2420 (comment)
I'm suggesting to come up with more robust macro usage. So far, I've converted USE_MIN macro usage. The patch exposes one more issue in the current CMake files:

GenerateNamedObjects("${KERNELDIR}/${I${float_char}MINKERNEL}" "" "i*min_k" false "" "" false ${float_type})

there's missing USE_MIN macro.

@marxin
Copy link
Contributor Author

marxin commented Feb 18, 2020

@martin-frbg What do you think about the suggested approach?

@martin-frbg
Copy link
Collaborator

I'm not yet convinced that it is worth the trouble to change lots of existing files (with the risk of missing one), just to replace a "negative" define with the equivalent "positive" one. For new files, your suggestion to #error out if none of the possible options was seen is certainly superior but I feel that retroactively changing the logic will just make diffs harder to follow.

@marxin
Copy link
Contributor Author

marxin commented Feb 19, 2020

Alright, I understand that the changes will be quite invasive.

@marxin marxin closed this Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants