riscv：Remove the manual unrolling in gemv_t_vector.c to performance better #5444
+19
−111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kernel/riscv64/gemv_t_vector.c
Outdated
| FLOAT_V_T va, vr, vx; | ||
| unsigned int gvl = 0; | ||
| FLOAT_V_T_M1 v_res; | ||
| size_t vlmax = VSETVL_MAX_M1(); |
Contributor
There was a problem hiding this comment.
Remove unused variable - as well as VSETVL_MAX_M1
Contributor
Author
There was a problem hiding this comment.
Done! Thank you for your thorough review!
Contributor
|
Looks good - seeing a 4x+ speedup from previous version. |
Collaborator
|
Thank you for the quick update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. The conclusion and detailed discussion can be found in the following link：
https://github.com/OpenMathLib/OpenBLAS/issues/5430
https://github.com/OpenMathLib/OpenBLAS/pull/5427