Makefile: Recognize -fdefault-integer-8 for LLVMs flang
#5540
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan André Reuter <jan@zyten.de>
Collaborator
|
CMake is good, I "only" forgot to push Makefile.system at the time... |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the discussion in #5536
When building OpenBLAS on
aarch64with LLVM Flang, tests would segmentation fault when building withINTERFACE64='1'. IIUC, this happens due to a mismatch in integer size between Fortran and C.Looking at
Makefile.system, onlyGFortranand the oldFlangare checked withINTERFACE64. So forflang-new/flang, no compiler flag is added. Checkingflang-new18 and newer, it seems to understand the-fdefault-integer-8flag, just likeGFortran.Therefore, change the tests slightly to also add
-fdefault-integer-8forFLANGNEW.This PR does not touch the CMake installation of OpenBLAS. At the first glance, this flag might be added there already, but this needs more investigation. I wanted to get this to work for the Makefile build first...