Skip to content
This repository was archived by the owner on May 18, 2019. It is now read-only.

Conversation

@perost
Copy link
Member

@perost perost commented Nov 14, 2017

  • Rename NFMod to NFModifier, since that's the actual package name.
  • Add instance tree hierarchy level to components, and have bindings
    keep track of which level they're from instead of keeping track of
    how many levels they've been pushed down.
  • Added Expression.SUBSCRIPTED_EXP to handle subscripting of
    expressions that can't be scalarized.
  • Add missing cases for Call.UNTYPED_MAP_CALL and CAll.TYPED_MAP_CALL
    to some Expression functions.

@OpenModelica-Hudson
Copy link
Member

The test suite is unstable according to OpenModelica_TEST_PULL_REQUEST 2017-11-14_14-54-16.

- Rename NFMod to NFModifier, since that's the actual package name.
- Add instance tree hierarchy level to components, and have bindings
  keep track of which level they're from instead of keeping track of
  how many levels they've been pushed down.
- Added Expression.SUBSCRIPTED_EXP to handle subscripting of
  expressions that can't be scalarized.
- Add missing cases for Call.UNTYPED_MAP_CALL and CAll.TYPED_MAP_CALL
  to some Expression functions.
@OpenModelica-Hudson
Copy link
Member

The tests run correctly according to OpenModelica_TEST_PULL_REQUEST 2017-11-14_15-11-12.

OpenModelica-Hudson pushed a commit that referenced this pull request Nov 14, 2017
- Rename NFMod to NFModifier, since that's the actual package name.
- Add instance tree hierarchy level to components, and have bindings
  keep track of which level they're from instead of keeping track of
  how many levels they've been pushed down.
- Added Expression.SUBSCRIPTED_EXP to handle subscripting of
  expressions that can't be scalarized.
- Add missing cases for Call.UNTYPED_MAP_CALL and CAll.TYPED_MAP_CALL
  to some Expression functions.

Belonging to [master]:
  - #2015
  - OpenModelica/OpenModelica-testsuite#779
OpenModelica-Hudson pushed a commit to OpenModelica/OpenModelica-testsuite that referenced this pull request Nov 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants