[OMCSessionZMQ] merge into OMCProcess #381
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rework of OMCSessioZMQ was done with the idea in mind to separate the different backends and add new ones (Local/Port/Docker/DockerContainer/WSL). Thus, the structure of one main class (OMCSessionZMQ) and the backend/process classes (OMCProcess*) was developed.
Overall, this is not a good concept as the user has to create an instance of OMCProcess to provide it to an instance of OMCSessionZMQ if anything but the default (local) session should be used.
This PR is a draft of a (re)morge of the functionality - use one base class (OMCProcess here; to be renamed to OMCSession) which (1) contains the code needed by all backends and derived backend classes which have all functionality to replace OMCSessionZMQ.
Thus, the user has to only load / instanciate one class and can work with OMC ...
Follow-up PRs are work in progress; this is a breaking change for v4.1.0. In this release it will contain a compatibility layer (OMCSessionZMQ) whoch could be removed in v5.0.0.
The final version can be checked out in https://github.com/syntron/OMPython/tree/remove_OMCSessionZMQ
Please comment!