Skip to content

use sys.exit on good paths to not create zombies #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adrpo merged 2 commits into from
Nov 6, 2024
Merged

use sys.exit on good paths to not create zombies #160

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
deb1a05
use sys.exit on good paths to not create zombies
adrpo Nov 6, 2024
5995ceb
fix syntax
adrpo Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions testmodel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,14 +42,23 @@ def writeResult():
fp.flush()
os.fsync(fp.fileno())

def writeResultAndExit(exitStatus):
startJob=monotonic()

def writeResultAndExit(exitStatus, useOsExit=False):
writeResult()
print("Calling exit ...")
with open(errFile, 'a+') as fp:
fp.write("[Calling os._exit(%s)]\n" % exitStatus)
if useOsExit:
msg = "[Calling os._exit(%s), Time elapsed: %s]\n"
else:
msg = "[Calling sys.exit(%s), Time elapsed: %s]\n"
fp.write(msg % (exitStatus, monotonic()-startJob))
fp.flush()
sys.stdout.flush()
os._exit(exitStatus)
if useOsExit:
os._exit(exitStatus)
else:
sys.exit(exitStatus)

def sendExpressionTimeout(omc, cmd, timeout):
with open(errFile, 'a+') as fp:
Expand Down Expand Up @@ -98,7 +107,7 @@ def target(res):
pass
with open(errFile, 'a+') as fp:
fp.write("Aborted the command.\n")
writeResultAndExit(0)
writeResultAndExit(0, True)
if res[1] is None:
res[1] = ""
if res[1] is not None:
Expand Down Expand Up @@ -314,7 +323,7 @@ def loadLibraryInNewOM():
execstat["parsing"]=monotonic()-start
with open(errFile, 'a+') as fp:
fp.write("Timeout error for cmd: %s\n%s"%(cmd,str(e)))
writeResultAndExit(0)
writeResultAndExit(0, True)
execstat["parsing"]=monotonic()-start

try:
Expand Down Expand Up @@ -458,7 +467,7 @@ def sendExpressionOldOrNew(cmd):
execstat["build"] = monotonic()-start
with open(errFile, 'a+') as fp:
fp.write(str(e))
writeResultAndExit(0)
writeResultAndExit(0, True)

writeResult()
# Do the simulation
Expand Down Expand Up @@ -508,7 +517,7 @@ def sendExpressionOldOrNew(cmd):
execstat["phase"] = 6
except TimeoutError as e:
execstat["sim"] = monotonic()-start
writeResultAndExit(0)
writeResultAndExit(0, True)

if referenceFile=="":
writeResultAndExit(0)
Expand Down