-
-
Notifications
You must be signed in to change notification settings - Fork 56
Datapack, performance and theme improvements. #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I am currently adding support for stereo in datapacks (and the program itself), so please allow me to apply those changes before accepting the push request. |
|
In order to get this to work nicely, I've updated the NBS File Format Version to 2, as under each layer volume section there are bytes for the layer's stereo panning. It loads previous versions to centre panning by default. I've also added an option to toggle between 30FPS and 60FPS, which should slightly alleviate #16 . Here is a song that should demonstrate the volume/stereo capabilities and datapack export The only things left to do now in #35 are to allow custom instrument names as /playsound IDs, and generate a resource pack for any non-default-minecraft custom instruments being used. |
Added alternative spriting in dark mode (easier to differentiate instruments), and added the option to enable/disable note block transparency animations (to improve performance if needed)
|
Added alternative sprites in dark theme (as the note block text contrasts with the background) for issue #34 |
For mods like tickratechanger, the tempo can go higher than 20. Programs could read the NBS file and translate it to tickrate change commands for the mod.
Added new sprites/icons for these instruments, and modified current custom instrument sprites.
This also stops a crash where the datapack exporter will not be able to export a song if it used custom instruments in the past. The custom instrument's playsound IDs are the name of the custom instrument. This allows regular minecraft sounds to be used as instruments.
It may cause issues with the way you made other people in the radius of the player hear music, so I'm leaving it for the default export type.