Skip to content

Conversation

@ShinkoNet
Copy link
Collaborator

It may cause issues with the way you made other people in the radius of the player hear music, so I'm leaving it for the default export type.

@ShinkoNet
Copy link
Collaborator Author

I am currently adding support for stereo in datapacks (and the program itself), so please allow me to apply those changes before accepting the push request.

@ShinkoNet ShinkoNet changed the title Add layer volume support to datapacks Add layer volume and stereo support to datapacks May 31, 2019
@ShinkoNet
Copy link
Collaborator Author

ShinkoNet commented May 31, 2019

In order to get this to work nicely, I've updated the NBS File Format Version to 2, as under each layer volume section there are bytes for the layer's stereo panning. It loads previous versions to centre panning by default.

I've also added an option to toggle between 30FPS and 60FPS, which should slightly alleviate #16 .

Here is a song that should demonstrate the volume/stereo capabilities and datapack export
stereo-test.zip

The only things left to do now in #35 are to allow custom instrument names as /playsound IDs, and generate a resource pack for any non-default-minecraft custom instruments being used.

@ShinkoNet ShinkoNet changed the title Add layer volume and stereo support to datapacks Add layer volume and stereo support to datapacks, add stereo to sound engine, performance improvements May 31, 2019
ShinkoNet and others added 3 commits June 1, 2019 13:45
Added alternative spriting in dark mode (easier to differentiate instruments), and added the option to enable/disable note block transparency animations (to improve performance if needed)
@ShinkoNet ShinkoNet changed the title Add layer volume and stereo support to datapacks, add stereo to sound engine, performance improvements Add layer volume and stereo support to datapacks, add stereo to sound engine, performance and theme improvements Jun 1, 2019
@ShinkoNet
Copy link
Collaborator Author

Added alternative sprites in dark theme (as the note block text contrasts with the background) for issue #34

ShinkoNet added 4 commits June 1, 2019 14:00
For mods like tickratechanger, the tempo can go higher than 20. Programs could read the NBS file and translate it to tickrate change commands for the mod.
Added new sprites/icons for these instruments, and modified current custom instrument sprites.
This also stops a crash where the datapack exporter will not be able to export a song if it used custom instruments in the past.
The custom instrument's playsound IDs are the name of the custom instrument. This allows regular minecraft sounds to be used as instruments.
@ShinkoNet ShinkoNet changed the title Add layer volume and stereo support to datapacks, add stereo to sound engine, performance and theme improvements Datapack, performance and theme improvements. Jun 1, 2019
This was referenced Jun 1, 2019
@HielkeMinecraft HielkeMinecraft merged commit 2d2703c into OpenNBS:master Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants