Report serverless metrics #424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradhilton
reviewed
Oct 3, 2025
src/art/serverless/backend.py
Outdated
Comment on lines
26
to
27
| self._wandb_runs: dict[str, Run] = {} | ||
| self._weave_clients: dict[str, WeaveClient] = {} |
There was a problem hiding this comment.
i don't think we need this
src/art/serverless/backend.py
Outdated
Comment on lines
7
to
8
| from wandb.sdk.wandb_run import Run | ||
| from weave.trace.weave_client import WeaveClient |
There was a problem hiding this comment.
i don't think we need this
src/art/client.py
Outdated
Comment on lines
94
to
102
| async def report_metrics( | ||
| self, *, model_id: str, step: int | Literal["latest"], metrics: dict[str, float] | ||
| ) -> ReportMetricsResponse: | ||
| return await self._post( | ||
| f"/preview/models/{model_id}/checkpoints/{step}/report_metrics", | ||
| body={"metrics": metrics}, | ||
| cast_to=ReportMetricsResponse, | ||
| options=dict(max_retries=0), | ||
| ) |
There was a problem hiding this comment.
i don't think we need this
src/art/client.py
Outdated
Comment on lines
41
to
42
| class ReportMetricsResponse(BaseModel): | ||
| success: bool |
There was a problem hiding this comment.
i don't think we need this
bradhilton
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.