Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Log to wait for items in worker thread #19342

Merged
merged 2 commits into from
Apr 26, 2021
Merged

Update Log to wait for items in worker thread #19342

merged 2 commits into from
Apr 26, 2021

Conversation

teinarss
Copy link
Contributor

@anvilvapre
Copy link
Contributor

The task will take a thread from a/some Thread pool. Seems fine if by that your solution can be clean as this.

What happens in the task thread? Would it be different your previous blocking while loop?

Curious to see how GetAwaiter is implemented. Since it is on a Channel I assume it is efficient in that i will use some producer consumer synchronization.

@teinarss teinarss force-pushed the Fix_logger1 branch 3 times, most recently from a2b9a33 to b80b497 Compare April 12, 2021 19:22
@teinarss
Copy link
Contributor Author

Updated.

@teinarss
Copy link
Contributor Author

Fixed.

@pchote pchote merged commit 5667081 into OpenRA:bleed Apr 26, 2021
@pchote
Copy link
Member

pchote commented Apr 26, 2021

https://github.com/OpenRA/OpenRA/wiki/Changelog-(bleed)/_compare/8ce6b1486d8d0a3e5e042fbde178d69e5fbf6475

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abcdefg30 abcdefg30 abcdefg30 approved these changes

@pchote pchote pchote approved these changes

Assignees
No one assigned
Labels
PR: Needs +2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@teinarss @anvilvapre @pchote @abcdefg30