Allow each armament to define ammo used #19362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abcdefg30
previously approved these changes
Jun 10, 2021
There was a problem hiding this comment.
Works as advertised. I wonder if we want to adjust the minelayer too:
OpenRA/OpenRA.Mods.Cnc/Activities/LayMines.cs
Line 150 in fe12995
You can also remove the testcase now.
done |
Smittytron
previously approved these changes
Jun 11, 2021
Smittytron
reviewed
Jun 11, 2021
fix gh actions
Smittytron
approved these changes
Jun 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows modders to make certain weapons use more ammo from the same pool than others. Test case included: RA Longbow should be only able to fire half as many missiles against air as it does against ground, no unexpected changes with behavior of other use cases so far.