Set _KDE_NET_WM_DESKTOP_FILE x11 window property. #19553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mailaender
reviewed
Jul 23, 2021
This explicitly tells KDE to associate the OpenRA window with the integrated appimage desktop file, allowing it to use the correct resolution icon for the task switcher.
|
Updated. |
Mailaender
approved these changes
Jul 26, 2021
abcdefg30
approved these changes
Aug 16, 2021
|
This doesn't work in the AppImage:
or it requires changes to the SDK scripts. |
|
It works fine for me, but of course you do need host integration (e.g. through AppImageLauncher) activated for this and any other icons/launchers/mime types to work. |
|
Okay, in that case #19528 was what I really wanted. I have never heard of https://github.com/TheAssassin/AppImageLauncher and I doubt many people use it. |
|
Yes, the desktop integration situation for AppImages is a real mess. They still state that individual applications managing their own integrations violates best practices, but provide no standard solution that we can expect users to willingly install. See AppImage/AppImageKit#1036 and related discussions for more information. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a small polish annoyance when running the appimages with https://github.com/TheAssassin/AppImageLauncher integrations. Different components in the KDE desktop seem to have different heuristics for matching windows to their icons, and this was the only way I could find to properly solve all of them.
I suggest reviewing with ?w=1 to get a clearer picture of what has actually changed.
Before:
After:
