Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Interactable lint test #20734

Merged
merged 1 commit into from
Mar 27, 2023
Merged

Add Interactable lint test #20734

merged 1 commit into from
Mar 27, 2023

Conversation

PunkPun
Copy link
Member

@PunkPun PunkPun commented Mar 8, 2023

Closes #11164
Closes #20555

Since #19174 bounds are calculated from WDist instead of pixels. This causes many of the older maps to crash games, And this lint test makes it easier for map makers to detect these issues.

As calculating the bounds requires MapGrid, we need to write a separate lint test for Interactable instead of defaulting to RulesetLoaded checks.

Since # 19174 bounds are calculated from WDist instead of pixels. This causes many of the older maps to crash games, And this lint test makes it easier for map makers to detect these issues.

As calculating the bounds requires MapGrid, we need to write a separate lint test for Interactable instead of defaulting to RulesetLoaded checks.
Copy link
Member

@RoosterDragon RoosterDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Looks good in testing to me.

@Mailaender Mailaender merged commit 925e042 into OpenRA:bleed Mar 27, 2023
@Mailaender
Copy link
Member

Changelog

@Mailaender
Copy link
Member

8aa6b83

@PunkPun PunkPun deleted the bounds branch March 27, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Utility doesn't check for valid bounds Additional useful lint tests
3 participants