Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2216 InstallShield .Z package decompression #3342

Merged
merged 1 commit into from May 26, 2013
Merged

Fixes #2216 InstallShield .Z package decompression #3342

merged 1 commit into from May 26, 2013

Conversation

baxtor
Copy link
Contributor

@baxtor baxtor commented May 26, 2013

Reverse engineered pascal code from "STIX", adjusted only a few line of code.
The blast implementation of OpenRA works perfectly with it.
Filename hashing should be removed 'cause of duplicate filenames in nested folders.

@Mailaender
Copy link
Member

ProTip: If you write "Fixes #2216" or "Closes #2216" in the commit comment the bug will automatically be closed once this is merged.

@baxtor
Copy link
Contributor Author

baxtor commented May 26, 2013

@Mailaender changed title message

chrisforbes added a commit that referenced this pull request May 26, 2013
Fixes #2216 InstallShield .Z package decompression
@chrisforbes chrisforbes merged commit 2958c80 into OpenRA:bleed May 26, 2013
@Mailaender
Copy link
Member

👎 Does not work.

System.IO.EndOfStreamException: Failed to read past end of stream.
  at System.IO.BinaryReader.FillBuffer (Int32 numBytes) [0x0006d] in /home/abuild/rpmbuild/BUILD/mono-3.0.7/mcs/class/corlib/System.IO/BinaryReader.cs:144 
  at System.IO.BinaryReader.ReadUInt32 () [0x00000] in /home/abuild/rpmbuild/BUILD/mono-3.0.7/mcs/class/corlib/System.IO/BinaryReader.cs:556 
  at OpenRA.FileFormats.InstallShieldPackage.ParseFile (System.IO.BinaryReader reader) [0x00009] in /home/matthias/Projekte/OpenRA/OpenRA.FileFormats/Filesystem/InstallShieldPackage.cs:76 
  at OpenRA.FileFormats.InstallShieldPackage.ParseDirectory (System.IO.BinaryReader reader) [0x00031] in /home/matthias/Projekte/OpenRA/OpenRA.FileFormats/Filesystem/InstallShieldPackage.cs:69 
  at OpenRA.FileFormats.InstallShieldPackage..ctor (System.String filename, Int32 priority) [0x000d4] in /home/matthias/Projekte/OpenRA/OpenRA.FileFormats/Filesystem/InstallShieldPackage.cs:53 
  at OpenRA.FileFormats.FileSystem.OpenPackage (System.String filename, System.String annotation, Int32 order) [0x0008b] in /home/matthias/Projekte/OpenRA/OpenRA.FileFormats/Filesystem/FileSystem.cs:75 
  at OpenRA.FileFormats.FileSystem+<Mount>c__AnonStorey15.<>m__16 () [0x00000] in /home/matthias/Projekte/OpenRA/OpenRA.FileFormats/Filesystem/FileSystem.cs:95 
  at OpenRA.FileFormats.FileSystem.Mount (System.String name, System.String annotation) [0x000ac] in /home/matthias/Projekte/OpenRA/OpenRA.FileFormats/Filesystem/FileSystem.cs:101 
  at OpenRA.FileFormats.FileSystem.Mount (System.String name) [0x00001] in /home/matthias/Projekte/OpenRA/OpenRA.FileFormats/Filesystem/FileSystem.cs:82 
  at OpenRA.FileFormats.InstallUtils.ExtractFromPackage (System.String srcPath, System.String package, System.String[] files, System.String destPath, System.Action`1 onProgress, System.Action`1 onError) [0x00063] in /home/matthias/Projekte/OpenRA/OpenRA.FileFormats/InstallUtils.cs:49 
  at OpenRA.Mods.D2k.Widgets.Logic.D2kInstallFromCDLogic+<Install>c__AnonStorey3.<>m__1D (System.Object _) [0x00000] in <filename unknown>:0 
  at System.Threading.Thread.StartInternal () [0x0002b] in /home/abuild/rpmbuild/BUILD/mono-3.0.7/mcs/class/corlib/System.Threading/Thread.cs:736 

@Mailaender
Copy link
Member

No, it was my code that is crap. In fact this works. 👍

@Mailaender
Copy link
Member

Mailaender@0d05861 with @baxtor's help will also enable the GUI properly for this. Part of my long-term branch addressing #2566.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants