Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save current group in scenario list window #9285

Closed
AaronVanGeffen opened this issue May 20, 2019 · 4 comments
Closed

Save current group in scenario list window #9285

AaronVanGeffen opened this issue May 20, 2019 · 4 comments
Labels
feature Add something new to the game. good-first-issue Low hanging fruits good for people new to open source or OpenRCT2.

Comments

@AaronVanGeffen
Copy link
Member

Something I've noticed playing Locomotion is that it remembers which scenario group (tab) was active last time the scenario list window was used. It uses the normal config struct to achieve this. We should be able to easily introduce something similar.

A potential pitfall is that OpenRCT2 allows you to change the scenario grouping type. The setting should be reset to the first tab when switching types. Such a reset should also happen if an invalid setting is encountered in general, e.g. because RCT1 is no longer linked, or if the config INI file has been tampered with.
@AaronVanGeffen AaronVanGeffen added feature Add something new to the game. good-first-issue Low hanging fruits good for people new to open source or OpenRCT2. labels May 20, 2019
@Spongeloaf
Copy link
Contributor

I'd like to give this one a shot. It sounds simple enough, but I'm sure I'll manage to crash the game a few dozen times.

@Spongeloaf
Copy link
Contributor

Spongeloaf commented Jun 13, 2019 •
edited
Loading

Should it be persistent across game sessions?

@AaronVanGeffen
Copy link
Member Author

AaronVanGeffen commented Jun 13, 2019 •
edited
Loading

Should it be persistent across game sessions?

That is what I had in mind, yes. You can use the game config for this. (No need for an interface in the options window, just save the tab number.)

@Spongeloaf
Copy link
Contributor

I've got it working already, I just need to do a little more digging to ensure edge cases won't be missed.

This was referenced Jun 17, 2019
Closed
Merged
Broxzier pushed a commit that referenced this issue Aug 23, 2019
@AaronVanGeffen
Update changelog for #9285, #9918. [ci skip]
0e795b3
Broxzier added a commit that referenced this issue Aug 23, 2019
@Broxzier
Merge pull request #9932 from AaronVanGeffen/changelog-update-1
f7ce9b1 
Update changelog for #9285, #9918
tupaschoal pushed a commit to tupaschoal/OpenRCT2 that referenced this issue Sep 23, 2019
@Spongeloaf @tupaschoal
OpenRCT2#9285 Add feature to remember scernario tab
176b74d
tupaschoal pushed a commit to tupaschoal/OpenRCT2 that referenced this issue Sep 23, 2019
@AaronVanGeffen @tupaschoal
Update changelog for OpenRCT2#9285, OpenRCT2#9918. [ci skip]
0d32c72
janisozaur added a commit that referenced this issue Oct 28, 2019
@janisozaur
Release 0.2.4
d645338 
- Feature: [#9285] Remember current group in scenario list window.
- Feature: [#9918] Increase image list capacity by about 100k units.
- Change: [#1349] Increase the number of ride music played simultaneously from 2 to 32.
- Fix: [#4927] Giant screenshot cut off at bottom and top.
- Fix: [#7572] Queue paths connect to regular paths through fences.
- Fix: [#7690] Problem with guests freezing on certain tiles of path.
- Fix: [#7883] Headless server log is stored incorrectly if server name contains CJK in Ubuntu
- Fix: [#8136] Excessive lateral G penalty is too excessive.
- Fix: [#8584] Duck spawning function does not check tiles with x or y coordinate of 0..64 (Original bug)
- Fix: [#9179] Crash when modifying a ride occasionally.
- Fix: [#9533] Door sounds not playing.
- Fix: [#9574] Text overflow in scenario objective window when using CJK languages.
- Fix: [#9603] Don't render audio when master volume is turned off.
- Fix: [#9625] Show correct cost in scenery selection.
- Fix: [#9669] The tile inspector shortcut key does not work with debugging tools disabled.
- Fix: [#9675] Guest entry point limit can be bypassed in scenario editor.
- Fix: [#9683] Cannot raise water level if part of the tool's area of effect is off of the map.
- Fix: [#9684] Entering custom size for water/land tool allows confirmation with main enter key, but not numpad enter key.
- Fix: [#9690] The keyboard shortcut for rotating the game view can be set to Enter or KP Enter, but not both.
- Fix: [#9717] Scroll bars do not render correctly when using OpenGL renderer.
- Fix: [#9729] Peeps do not take into account height difference when deciding to pathfind to a ride entrance (original bug).
- Fix: [#9902] Doors/Portcullis do not check to make sure doors are open causing double opens.
- Fix: [#9926] Africa - Oasis park has wrong peep spawn (original bug).
- Fix: [#9953] Crash when hacked rides attempt to find the closest mechanic.
- Fix: [#9955] Resizing map in while pause mode does not work and may result in freezes.
- Fix: [#9957] When using 'no money' cheat, guests complain of running out of cash.
- Fix: [#9970] Wait for quarter load fails.
- Fix: [#9994] Game action tick collision during server connect and map load.
- Fix: [#10017] Ghost elements influencing ride excitement.
- Fix: [#10036] Do not allocate large chunks of memory for save file classification.
- Fix: [#10106] Ride circuits should not be used for modes that do not support it.
- Fix: [#10149] Desync in headless mode with rides that create smoke particles.
- Improved: [#9466] Add the rain weather effect to the OpenGL renderer.
- Improved: [#9987] Minimum load rounding.
- Improved: [#10125] Better support for high DPI screens.
XplosiveLugnut pushed a commit to XplosiveLugnut/OpenRCT2 that referenced this issue Apr 27, 2020
@AaronVanGeffen
Update changelog for OpenRCT2#9285, OpenRCT2#9918. [ci skip]
2c6085d
XplosiveLugnut pushed a commit to XplosiveLugnut/OpenRCT2 that referenced this issue Apr 27, 2020
@janisozaur
Release 0.2.4
d6749fb 
- Feature: [OpenRCT2#9285] Remember current group in scenario list window.
- Feature: [OpenRCT2#9918] Increase image list capacity by about 100k units.
- Change: [OpenRCT2#1349] Increase the number of ride music played simultaneously from 2 to 32.
- Fix: [OpenRCT2#4927] Giant screenshot cut off at bottom and top.
- Fix: [OpenRCT2#7572] Queue paths connect to regular paths through fences.
- Fix: [OpenRCT2#7690] Problem with guests freezing on certain tiles of path.
- Fix: [OpenRCT2#7883] Headless server log is stored incorrectly if server name contains CJK in Ubuntu
- Fix: [OpenRCT2#8136] Excessive lateral G penalty is too excessive.
- Fix: [OpenRCT2#8584] Duck spawning function does not check tiles with x or y coordinate of 0..64 (Original bug)
- Fix: [OpenRCT2#9179] Crash when modifying a ride occasionally.
- Fix: [OpenRCT2#9533] Door sounds not playing.
- Fix: [OpenRCT2#9574] Text overflow in scenario objective window when using CJK languages.
- Fix: [OpenRCT2#9603] Don't render audio when master volume is turned off.
- Fix: [OpenRCT2#9625] Show correct cost in scenery selection.
- Fix: [OpenRCT2#9669] The tile inspector shortcut key does not work with debugging tools disabled.
- Fix: [OpenRCT2#9675] Guest entry point limit can be bypassed in scenario editor.
- Fix: [OpenRCT2#9683] Cannot raise water level if part of the tool's area of effect is off of the map.
- Fix: [OpenRCT2#9684] Entering custom size for water/land tool allows confirmation with main enter key, but not numpad enter key.
- Fix: [OpenRCT2#9690] The keyboard shortcut for rotating the game view can be set to Enter or KP Enter, but not both.
- Fix: [OpenRCT2#9717] Scroll bars do not render correctly when using OpenGL renderer.
- Fix: [OpenRCT2#9729] Peeps do not take into account height difference when deciding to pathfind to a ride entrance (original bug).
- Fix: [OpenRCT2#9902] Doors/Portcullis do not check to make sure doors are open causing double opens.
- Fix: [OpenRCT2#9926] Africa - Oasis park has wrong peep spawn (original bug).
- Fix: [OpenRCT2#9953] Crash when hacked rides attempt to find the closest mechanic.
- Fix: [OpenRCT2#9955] Resizing map in while pause mode does not work and may result in freezes.
- Fix: [OpenRCT2#9957] When using 'no money' cheat, guests complain of running out of cash.
- Fix: [OpenRCT2#9970] Wait for quarter load fails.
- Fix: [OpenRCT2#9994] Game action tick collision during server connect and map load.
- Fix: [OpenRCT2#10017] Ghost elements influencing ride excitement.
- Fix: [OpenRCT2#10036] Do not allocate large chunks of memory for save file classification.
- Fix: [OpenRCT2#10106] Ride circuits should not be used for modes that do not support it.
- Fix: [OpenRCT2#10149] Desync in headless mode with rides that create smoke particles.
- Improved: [OpenRCT2#9466] Add the rain weather effect to the OpenGL renderer.
- Improved: [OpenRCT2#9987] Minimum load rounding.
- Improved: [OpenRCT2#10125] Better support for high DPI screens.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature Add something new to the game. good-first-issue Low hanging fruits good for people new to open source or OpenRCT2.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AaronVanGeffen @Spongeloaf