Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vertical Height is not taken into account when choosing which entrance to path to #9729

Closed
jbreitung opened this issue Aug 5, 2019 · 5 comments
Closed

Vertical Height is not taken into account when choosing which entrance to path to #9729

jbreitung opened this issue Aug 5, 2019 · 5 comments
Labels
good-first-issue Low hanging fruits good for people new to open source or OpenRCT2. original bug This was an issue in the original game already.

Comments

@jbreitung
Copy link

OS: Windows 10
Version: 0.2.3
Commit/Build: ac7a1eb

I found out that people are getting stuck when building big paths (2 or 3 blocks thick). This issue also occures with maintenance workers when they are called to repair something.

  • not Reproducible in RCT2 (vanilla)

Steps to reproduce:

  1. Download my savegame
  2. Go to the location you can see in the screenshot

Screenshots / Video:
People_stuck_on_big_path

Save game:
UltimatoPark.zip
@duncanspumpkin
Copy link
Contributor

Thats not a great layout for a park in terms of pathing. The ai is not designed for this layout at all and you have made a classic U shaped trap for the peeps (they have to move further away from the destination to get closer to it). I strongly suspect the vanilla game would also suffer from this but perhaps in a slightly different way.

@duncanspumpkin duncanspumpkin added the duplicate Issue already existed. label Aug 5, 2019
@duncanspumpkin
Copy link
Contributor

image

@duncanspumpkin
Copy link
Contributor

Actually on further inspection its because you have two entrances and its trying to path to the nearest which is the top one.

@duncanspumpkin duncanspumpkin added good-first-issue Low hanging fruits good for people new to open source or OpenRCT2. original bug This was an issue in the original game already. and removed duplicate Issue already existed. labels Aug 5, 2019
@duncanspumpkin duncanspumpkin changed the title People stuck on big paths Vertical Height is not taken into account when choosing which entrance to path to Aug 5, 2019
@duncanspumpkin duncanspumpkin reopened this Aug 5, 2019
@duncanspumpkin
Copy link
Contributor

duncanspumpkin commented Aug 5, 2019 •
edited
Loading

https://github.com/OpenRCT2/OpenRCT2/blob/develop/src/openrct2/peep/GuestPathfinding.cpp#L2076

Should be modified to add a component from the Z delta between the peep->next_z and the entranceLocation.z. (zDelta / 2 would be a good factor as it would match later pathing calcs see L796)

Note this will be modifing the game logic and will require a network version increment.

@duncanspumpkin
Copy link
Contributor

After adding the appropriate factor
image

tupaschoal pushed a commit to tupaschoal/OpenRCT2 that referenced this issue Sep 23, 2019
@duncanspumpkin @tupaschoal
Fix OpenRCT2#9729. Change peep pathfinding to take entrance height in…
9dd6fcf 
…to account

When choosing which entrance to head to peeps would not take into account the height difference between the locations. This caused peeps to choose badly especially when useing lift transport rides.
janisozaur added a commit that referenced this issue Oct 28, 2019
@janisozaur
Release 0.2.4
d645338 
- Feature: [#9285] Remember current group in scenario list window.
- Feature: [#9918] Increase image list capacity by about 100k units.
- Change: [#1349] Increase the number of ride music played simultaneously from 2 to 32.
- Fix: [#4927] Giant screenshot cut off at bottom and top.
- Fix: [#7572] Queue paths connect to regular paths through fences.
- Fix: [#7690] Problem with guests freezing on certain tiles of path.
- Fix: [#7883] Headless server log is stored incorrectly if server name contains CJK in Ubuntu
- Fix: [#8136] Excessive lateral G penalty is too excessive.
- Fix: [#8584] Duck spawning function does not check tiles with x or y coordinate of 0..64 (Original bug)
- Fix: [#9179] Crash when modifying a ride occasionally.
- Fix: [#9533] Door sounds not playing.
- Fix: [#9574] Text overflow in scenario objective window when using CJK languages.
- Fix: [#9603] Don't render audio when master volume is turned off.
- Fix: [#9625] Show correct cost in scenery selection.
- Fix: [#9669] The tile inspector shortcut key does not work with debugging tools disabled.
- Fix: [#9675] Guest entry point limit can be bypassed in scenario editor.
- Fix: [#9683] Cannot raise water level if part of the tool's area of effect is off of the map.
- Fix: [#9684] Entering custom size for water/land tool allows confirmation with main enter key, but not numpad enter key.
- Fix: [#9690] The keyboard shortcut for rotating the game view can be set to Enter or KP Enter, but not both.
- Fix: [#9717] Scroll bars do not render correctly when using OpenGL renderer.
- Fix: [#9729] Peeps do not take into account height difference when deciding to pathfind to a ride entrance (original bug).
- Fix: [#9902] Doors/Portcullis do not check to make sure doors are open causing double opens.
- Fix: [#9926] Africa - Oasis park has wrong peep spawn (original bug).
- Fix: [#9953] Crash when hacked rides attempt to find the closest mechanic.
- Fix: [#9955] Resizing map in while pause mode does not work and may result in freezes.
- Fix: [#9957] When using 'no money' cheat, guests complain of running out of cash.
- Fix: [#9970] Wait for quarter load fails.
- Fix: [#9994] Game action tick collision during server connect and map load.
- Fix: [#10017] Ghost elements influencing ride excitement.
- Fix: [#10036] Do not allocate large chunks of memory for save file classification.
- Fix: [#10106] Ride circuits should not be used for modes that do not support it.
- Fix: [#10149] Desync in headless mode with rides that create smoke particles.
- Improved: [#9466] Add the rain weather effect to the OpenGL renderer.
- Improved: [#9987] Minimum load rounding.
- Improved: [#10125] Better support for high DPI screens.
XplosiveLugnut pushed a commit to XplosiveLugnut/OpenRCT2 that referenced this issue Apr 27, 2020
@duncanspumpkin
Fix OpenRCT2#9729. Change peep pathfinding to take entrance height in…
28e8278 
…to account

When choosing which entrance to head to peeps would not take into account the height difference between the locations. This caused peeps to choose badly especially when useing lift transport rides.
XplosiveLugnut pushed a commit to XplosiveLugnut/OpenRCT2 that referenced this issue Apr 27, 2020
@janisozaur
Release 0.2.4
d6749fb 
- Feature: [OpenRCT2#9285] Remember current group in scenario list window.
- Feature: [OpenRCT2#9918] Increase image list capacity by about 100k units.
- Change: [OpenRCT2#1349] Increase the number of ride music played simultaneously from 2 to 32.
- Fix: [OpenRCT2#4927] Giant screenshot cut off at bottom and top.
- Fix: [OpenRCT2#7572] Queue paths connect to regular paths through fences.
- Fix: [OpenRCT2#7690] Problem with guests freezing on certain tiles of path.
- Fix: [OpenRCT2#7883] Headless server log is stored incorrectly if server name contains CJK in Ubuntu
- Fix: [OpenRCT2#8136] Excessive lateral G penalty is too excessive.
- Fix: [OpenRCT2#8584] Duck spawning function does not check tiles with x or y coordinate of 0..64 (Original bug)
- Fix: [OpenRCT2#9179] Crash when modifying a ride occasionally.
- Fix: [OpenRCT2#9533] Door sounds not playing.
- Fix: [OpenRCT2#9574] Text overflow in scenario objective window when using CJK languages.
- Fix: [OpenRCT2#9603] Don't render audio when master volume is turned off.
- Fix: [OpenRCT2#9625] Show correct cost in scenery selection.
- Fix: [OpenRCT2#9669] The tile inspector shortcut key does not work with debugging tools disabled.
- Fix: [OpenRCT2#9675] Guest entry point limit can be bypassed in scenario editor.
- Fix: [OpenRCT2#9683] Cannot raise water level if part of the tool's area of effect is off of the map.
- Fix: [OpenRCT2#9684] Entering custom size for water/land tool allows confirmation with main enter key, but not numpad enter key.
- Fix: [OpenRCT2#9690] The keyboard shortcut for rotating the game view can be set to Enter or KP Enter, but not both.
- Fix: [OpenRCT2#9717] Scroll bars do not render correctly when using OpenGL renderer.
- Fix: [OpenRCT2#9729] Peeps do not take into account height difference when deciding to pathfind to a ride entrance (original bug).
- Fix: [OpenRCT2#9902] Doors/Portcullis do not check to make sure doors are open causing double opens.
- Fix: [OpenRCT2#9926] Africa - Oasis park has wrong peep spawn (original bug).
- Fix: [OpenRCT2#9953] Crash when hacked rides attempt to find the closest mechanic.
- Fix: [OpenRCT2#9955] Resizing map in while pause mode does not work and may result in freezes.
- Fix: [OpenRCT2#9957] When using 'no money' cheat, guests complain of running out of cash.
- Fix: [OpenRCT2#9970] Wait for quarter load fails.
- Fix: [OpenRCT2#9994] Game action tick collision during server connect and map load.
- Fix: [OpenRCT2#10017] Ghost elements influencing ride excitement.
- Fix: [OpenRCT2#10036] Do not allocate large chunks of memory for save file classification.
- Fix: [OpenRCT2#10106] Ride circuits should not be used for modes that do not support it.
- Fix: [OpenRCT2#10149] Desync in headless mode with rides that create smoke particles.
- Improved: [OpenRCT2#9466] Add the rain weather effect to the OpenGL renderer.
- Improved: [OpenRCT2#9987] Minimum load rounding.
- Improved: [OpenRCT2#10125] Better support for high DPI screens.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good-first-issue Low hanging fruits good for people new to open source or OpenRCT2. original bug This was an issue in the original game already.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@duncanspumpkin @jbreitung