Change column names upon project start #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wetneb
approved these changes
Oct 20, 2022
Member
wetneb
left a comment
wetneb
left a comment
There was a problem hiding this comment.
Looks good to me! You could add a few assertions in some existing test, too.
j-sal
force-pushed
the
75-column-names
branch
from
5d016f6 to
98ebc11
Compare
wetneb
reviewed
Oct 31, 2022
| Assert.assertEquals(project.columnModel.columns.get(1).getName(), "M-ids"); | ||
| Assert.assertEquals(project.columnModel.columns.get(2).getName(), "Categories"); | ||
| Assert.assertEquals(cell.recon.match.id, "M114916202"); | ||
| Assert.assertEquals(cell.recon.match.name, "File:2006-08-08 Vista Parque Nacional Volcan Arenal, Costa Rica.jpg"); |
Member
There was a problem hiding this comment.
Very nice! One problem though: this test case seems to be fetching data from Wikimedia Commons without any mocking, so it is likely that the test will start failing whenever the contents of this category change. I would rather mock the API call with MockWebServer as in other tests. This might require a method to set the MediaWiki API endpoint to use in CommonsImporter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #75