Merged
Conversation
peterMuriuki
force-pushed
the
93-catalogueListView
branch
from
9bef995 to
086b865
Compare
peterMuriuki
force-pushed
the
93-productForm
branch
from
918963f to
59f893d
Compare
peterMuriuki
requested review from
HaseemUlHaq,
ashfahan,
kahummer,
kelvin-muchiri and
moshthepitt
moshthepitt
reviewed
Nov 16, 2020
| productPhoto: string | File; | ||
| }; | ||
|
|
||
| const defaultInitialValues: Partial<ProductFormFields> = { |
Contributor
There was a problem hiding this comment.
Does it need to be Partial if we are going to have properties set as undefined?
Contributor
Author
There was a problem hiding this comment.
will remove partial, remove the redundancy.
moshthepitt
approved these changes
Nov 16, 2020
kahummer
approved these changes
Nov 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-> Adds the form component that wil be used to create or edit products.