Detected Objects adapted to real sensor structures. #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmai
reviewed
Jan 24, 2018
osi_detectedobject.proto
Outdated
|
|
||
| // Definition of measurement states. | ||
| // | ||
| enum MeasurementState |
Contributor
There was a problem hiding this comment.
Would it make sense to move this enum also to the DetectedObjectHeader, which would make reuse simpler (see my comments in PR #111 )?
osi_detectedobject.proto
Outdated
| // | ||
| // \brief The header attributes of each detected object. | ||
| // | ||
| message DetectedObjectHeader |
Contributor
There was a problem hiding this comment.
Maybe also move the DetectedObjectHeader definition out of DetectedObject, to make reuse easier?
jondo2010
reviewed
Jan 29, 2018
osi_detectedobject.proto
Outdated
|
|
||
| // Continuous up counter to identify the cycle. | ||
| // | ||
| optional uint32 cylcle_counter = 3; |
pmai
force-pushed
the
OSI-Detected-messages-prepared-for-standardised-real-sensor-output
branch
from
d34dcbc to
b7e6e7b
Compare
DetectedObject is adapted to standardised real sensor output structures. Other detected objects (like traffic sign/light etc.) are prepared.
pmai
force-pushed
the
OSI-Detected-messages-prepared-for-standardised-real-sensor-output
branch
from
b7e6e7b to
e3a6311
Compare
added 2 commits
February 6, 2018 03:24
DetectedObjectHeader message moved out of DetectedObject message. Enum MovementState moved out of DetectedObject message. Remove Typos and adjust documentation. Include suggestions from issue #49.
Change specification of body poses from yaw angle to 3d orientation.
pmai
force-pushed
the
OSI-Detected-messages-prepared-for-standardised-real-sensor-output
branch
from
e3a6311 to
613bc6c
Compare
pmai
deleted the
OSI-Detected-messages-prepared-for-standardised-real-sensor-output
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DetectedObject is adapted to standardised real sensor output structures. Other detected objects (like traffic sign/light etc.) are prepared.
DetectedObject list is adapted to the standardisation activities for real sensors. Other detected objects are draft.