Replacing semantic Traffic Lights with Traffic Light Bulbs (issue #70) #160
Conversation
ghost
requested a review
from 
ghost
added
the
FeatureRequest
osi_landmark.proto
Outdated
| // The base parameters of the traffic light. | ||
| // | ||
| // \c BaseStationary::orientation x-axis is view normal of the traffic | ||
| // sign's icon. |
osi_landmark.proto
Outdated
| // geometrical arrangement) and the state \c TrafficLight::mode is | ||
| // \c MODE_OFF then \c TrafficLight::color could remain unchanged. | ||
| // If The traffic light displays different images in different colors, | ||
| // then \c TrafficLight::mode |
There was a problem hiding this comment.
something missing to finish that sentence?
| // This traffic light counter in percent. | ||
| // | ||
| ICON_COUNTDOWN_PERCENT = 22; | ||
| } |
There was a problem hiding this comment.
What about Bus, Bus_and_Tram (yes they exist :)
|
@ppannusch Thx. I add the buses and remove the typos. |
pmai
force-pushed
the
update/traffic_light
branch
from
9cf26e2 to
2b8dc18
Compare
|
@carsten-kuebler I've rebased onto master and fixed (as far as I can tell) the spurious conflicts (this branch always won), so please git checkout update/traffic_light && git fetch && git reset --hard origin/update/traffic_light prior to further changes... |
|
@carsten-kuebler I accidently pressed update branch... I will review and you can do as P.Mai suggests on the prior commit, work in the review and push afterwards. |
pmai
force-pushed
the
update/traffic_light
branch
from
e12d219 to
929012f
Compare
|
@carsten-kuebler, @CarloVanDriestenBMW rebased and conflict-free, should be mergeable now. |
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
I think we should add the supplementary sign "baseStationary" as discussed in this PR
osi_detectedlandmark.proto
Outdated
| // A list of candidates for (a) possible supplementary sign(s) as estimated by the sensor. | ||
| // | ||
| // A list of candidates for (a) possible supplementary sign(s) as estimated | ||
| // by the sensor. |
Review and reformating of documentation. Unifying enum names. Change Traffic Lights from semantic representation (light box) to syntactic representation (light bulbs)
TrafficLight defines one "bulb" and not one "box" e.g. red, yello green. Now every "bulb" is a separate message.
Remove Typos Add buses to traffic light icons.
pmai
force-pushed
the
update/traffic_light
branch
from
929012f to
dd19945
Compare
|
@CarloVanDriestenBMW Fixed up Doxygen and rebased to remove conflicts from new master. |
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
@carsten-kuebler I will merge this one and the other changes to the traffic lights will be done in a seperate PR in order to keep the master as up to date a s possible
This PR addresses issue #70 .
Review and reformating of documentation.
Unifying enum names.
Change Traffic Lights from semantic representation (light box) to syntactic representation (light bulbs)