-
Notifications
You must be signed in to change notification settings - Fork 130
Review documentation and add BaseStationary to supplementary signs #167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
2309cf5
Review documentation and add BaseStationary to supplementary signs
carsten-kuebler 84fa546
Regularized the Doxygen comments.
carsten-kuebler c4e4fec
Regularized the Doxygen comments.
carsten-kuebler cdc331c
Regularized the Doxygen comments.
carsten-kuebler caa1403
Regularized the Doxygen comments.
carsten-kuebler 3f4abab
Bugfix
carsten-kuebler a2051e2
Fix links.
carsten-kuebler 86c57f3
Regularized the Doxygen comments.
carsten-kuebler 5383b02
Regularized the Doxygen comments.
carsten-kuebler 47e3445
Fix doxygen links.
carsten-kuebler b0afb29
Regularized the Doxygen comments.
carsten-kuebler 98db423
Merge branch 'master' into Documentation-Review3
carsten-kuebler ca26298
Removed typo.
carsten-kuebler e6b0e76
Correct Documentation
carsten-kuebler 1335a83
Naming conventions
carsten-kuebler 1e0ba34
Duplicated MeasurementState removed
carsten-kuebler 74dd76d
Review
carsten-kuebler 5d09b97
Review
carsten-kuebler 8c7c946
All Identifier field names with postfix _id
carsten-kuebler d02b5a1
Rename EstimatedXXX messages to DetectedXXXData.
carsten-kuebler 672deb8
More DetectedXXX messages unified
carsten-kuebler e33ab45
fixed merge conflicts with master
jdsika 2e61c54
Merge branch 'master' into Documentation-Review3
jdsika 179d4d8
removed tabs in osi_sensordata.proto
jdsika 70d5b01
fixed merge conflict in osi_sensorview.proto
jdsika 56d0c15
Fixed enum style, unknow=, other=, etc,
jdsika 5d7725d
Reviewed Merge
carsten-kuebler a4fe010
Review...
carsten-kuebler 27c9921
Reviewed...
carsten-kuebler e519f52
checked for plural forms and added notice for singular usage
jdsika 8fc2004
Reviewed
carsten-kuebler 6a6584c
removed tab and resolved merge conflict
jdsika d58011a
Merge branch 'Documentation-Review3' of https://github.com/OpenSimula…
jdsika 7327dd7
Spaces and Tabs removed
carsten-kuebler File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sensor_data_series
The word series is both singular and plural. Same case as "data"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please note that you would adress
sensor_data_series (SensorDataSeriesList) --> sensor_data (SensorDataSeries) -> ...
often you find in OSI like:
sensor(s) (you get a message SensorDataSeries) -> data (you get a message SensorData) -> ...