-
Notifications
You must be signed in to change notification settings - Fork 130
Remove RelevantLane and RelevantDirection in Detected... #168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Question: |
|
Yes. Would you leave the associated_lane_id(s) empty? I would use associated_lane_id(s) as a best guess of the sensor... |
|
@carsten-kuebler where is the "associated_lane_id" ? So: The sensor has a "detectedLane" and a "DetectedTrafficSign" and within the sign we have an associated_lane_id ? |
|
Yes in the standard case (all referenced IDs are "local" in a SensorData message/message sequence). Could there be also the case that there are HD maps and these are used/referenced by the DetectedTrafficSigns? |
|
hm good question! |
|
It is easier to remove the messages and avoid the merge... |
|
@carsten-kuebler I think we need the relevant lane and reference the DetectedLanes in here. The relevant direction is redundant because of the icon AND the fact that the association with a specific lane gives the direction relevance. |
…and SupplementarySign - removed it from TrafficSign
Remove RelevantLane and RelevantDirection.
Relevant lanes and directions are defined in Candidate... assigned_lanes and traffic light's icons.