Skip to content

Conversation

@carsten-kuebler
Copy link
Contributor

Remove RelevantLane and RelevantDirection.
Relevant lanes and directions are defined in Candidate... assigned_lanes and traffic light's icons.

Remove RelevantLane and RelevantDirection.
Relevant lanes and directions are defined in Candidate... assigned_lanes and traffic light's icons.
@carsten-kuebler carsten-kuebler added the Duplicate This issue has already been raised or was already solved. label Mar 22, 2018
@carsten-kuebler carsten-kuebler added this to the v3.0.0 milestone Mar 22, 2018
@carsten-kuebler carsten-kuebler added the Suggestions I just want to drop by and leave this suggestion to think about. label Mar 23, 2018
@ghost
Copy link

ghost commented Mar 26, 2018

Question:
I think how I understand these fields now, they represent the "best guess" of the sensor on what it thinks is the assoziated lane and not the lane it is actually assigned to!

@carsten-kuebler
Copy link
Contributor Author

Yes. Would you leave the associated_lane_id(s) empty? I would use associated_lane_id(s) as a best guess of the sensor...

@ghost
Copy link

ghost commented Mar 27, 2018

@carsten-kuebler where is the "associated_lane_id" ? So:

The sensor has a "detectedLane" and a "DetectedTrafficSign" and within the sign we have an associated_lane_id ?

@carsten-kuebler
Copy link
Contributor Author

Yes in the standard case (all referenced IDs are "local" in a SensorData message/message sequence).

Could there be also the case that there are HD maps and these are used/referenced by the DetectedTrafficSigns?

@ghost
Copy link

ghost commented Mar 27, 2018

hm good question!
the map data and the detected lane would be merged by the sensor and the (also) merged traffic sign in the map would be assoziated with the (newly fused) detected lane?

@carsten-kuebler
Copy link
Contributor Author

It is easier to remove the messages and avoid the merge...

@ghost
Copy link

ghost commented Mar 28, 2018

@carsten-kuebler I think we need the relevant lane and reference the DetectedLanes in here. The relevant direction is redundant because of the icon AND the fact that the association with a specific lane gives the direction relevance.

@ghost ghost merged commit 224cfe4 into master Mar 28, 2018
@ghost ghost deleted the Suggestion/Remove_Relevant_Lane_and_Direction branch March 28, 2018 08:37
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Duplicate This issue has already been raised or was already solved. Suggestions I just want to drop by and leave this suggestion to think about.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants