Landmarks added (issue #166) #170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add landmarks and detected landmarks as new OSI messages. Add landmarks to GT and detected landmarks to SensorData. Move field measurement_state to Candidate... messages.
Update datatype to uint64 for cycle_counter.
carsten-kuebler
added
the
FeatureRequest
SebastianSchmidtBMW
suggested changes
Mar 23, 2018
osi_detectedlandmark.proto
Outdated
| { | ||
| // The description of the road marking. | ||
| // | ||
| optional RoadMarking road_marking = 1; |
There was a problem hiding this comment.
This should be optional Landmark landmark , since we describe CandidateLandmark here, shouldn't it?
The comment should be changed accordingly.
Contributor
Author
There was a problem hiding this comment.
Yes. Thx. I made a bugfix.
Correction of the faulty OSI message CandidateLandmark
SebastianSchmidtBMW
approved these changes
Mar 23, 2018
ghost
approved these changes
Mar 23, 2018
ghost
merged commit 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #166.
Add landmarks and detected landmarks as new OSI messages.
Add landmarks to GT and detected landmarks to SensorData.
Move field measurement_state to Candidate... messages.