Feature/cmake install #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmai
added
the
FeatureRequest
Contributor
Author
|
@CarloVanDriestenBMW not yet ready for merging (awaiting CMAKE_INSTALL_PREFIX fixes), created the PR to keep track of this for 3.x. Will inform when ready to merge. |
|
@FabeleAltran will push the change. I add you to the developers. |
The cmake file from current master branch is reused and adjusted to allow several OSI versions on the same computer. The main idea is to install into a directory that takes the version into account. This draft uses the major version described inside the version file to configure the installation path.
This change improves CI builds to also test the installation cmake targets for proper completion.
pmai
force-pushed
the
feature/cmake-install
branch
from
4f69066 to
e19829d
Compare
This is done to enable users to run OSI 2.x (package osi) and OSI 3.x (package osi3) side-by-side.
pmai
force-pushed
the
feature/cmake-install
branch
from
e19829d to
725f182
Compare
Contributor
Author
|
@CarloVanDriestenBMW rebased, fixes are in, so can be merged now. |
ghost
approved these changes
Mar 28, 2018
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add separate installation paths and new osi3 package for OSI 3.x.x release.