Skip to content

Conversation

@pmai
Copy link
Contributor

@pmai pmai commented Mar 27, 2018

Also fixes minor merge-induced regressions in comments

@pmai pmai added this to the v3.0.0 milestone Mar 27, 2018
@pmai pmai self-assigned this Mar 27, 2018
@pmai pmai requested a review from a user March 27, 2018 22:46
package osi;

//
// \brief The sensor view as derived from \c GroundTruth and used as
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is derived

// The virtual position pertains to the sensor as a whole, regardless
// of the actual position of individual physical detectors, and governs
// the sensor-relative coordinates in detected objects of the sensor
// as a whole. Individual features detected by individual physical
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 spaces

//
optional MountingPosition mounting_position_rmse = 5;

// Host Vehicle Data
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

//
optional HostVehicleData host_vehicle_data = 6;

// Ground truth w.r.t. global coordinate system
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

//
optional Identifier host_vehicle_id = 8;

// Radar-Specific SensorView(s)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

// Ray Tracing Data
//
// This field includes one entry for each ray, in left-to-right,
// top-to-bottom order (think scan lines in a TV).
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

of

//
optional LidarSensorViewConfiguration view_configuration = 1;

// Ray Tracing Data.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

caps

// Ray Tracing Data.
//
// This field includes one entry for each ray, in left-to-right,
// top-to-bottom order (think scan lines in a TV).
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

of

{
// Relative signal level of the reflection.
//
// This takes the combined_antenna_diagram (losses in TX and RX)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the definition for a Lidar must be different here...

//
optional CameraSensorViewConfiguration view_configuration = 1;

// Raw Image Data.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

caps

pmai and others added 2 commits March 28, 2018 09:08
@pmai pmai force-pushed the fix/line-endings branch from 94ba52a to c31de91 Compare March 28, 2018 07:11
@pmai pmai merged commit 2457074 into master Mar 28, 2018
@ghost ghost deleted the fix/line-endings branch March 29, 2018 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants