Skip to content

Conversation

@pmai
Copy link
Contributor

@pmai pmai commented Mar 28, 2018

This PR adds generic sensor sub views (and sub configurations) to address physical sensors which either do not match the other technologies, or do not wish to use the services provided for those. This is a minimal PR, not splitting up ground-truth generation and making it view and sensor-coordinate specific.

This PR also addresses the use of doubles for times in SensorViewConfiguration, changing those to be Timestamps.

pmai added 2 commits March 28, 2018 10:20
This is intended for physical sensors not matching any of the currently
specified sensor technologies (or not wanting to make use of those
views).
@pmai pmai added the FeatureRequest Proposals which enhance the interface or add additional features. label Mar 28, 2018
@pmai pmai added this to the v3.0.0 milestone Mar 28, 2018
@pmai pmai self-assigned this Mar 28, 2018
@pmai pmai requested a review from a user March 28, 2018 08:26
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@ghost ghost merged commit ba73472 into master Mar 28, 2018
@ghost ghost deleted the feature/genericsensorview branch March 28, 2018 08:56
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FeatureRequest Proposals which enhance the interface or add additional features.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants