Skip to content

Conversation

@mbinna
Copy link
Contributor

@mbinna mbinna commented Feb 8, 2017

This config file causes Travis CI to build this project with a matrix
build job. More information:

@mbinna
Copy link
Contributor Author

mbinna commented Feb 8, 2017

Hmm, I need to have a deeper look into the documentation of Travis. I'll update this pull request later.

@cmuck
Copy link
Contributor

cmuck commented Feb 8, 2017

The build fails due to the CMake minimum required version 3.7.
Travis CI build machines are based on Ubuntu 12.04 LTS 64 bit.

@mbinna
Copy link
Contributor Author

mbinna commented Feb 8, 2017

Sorry for the many commits. Travis CI is really picky regarding CMake and protobuf due to its old Ubuntu version.

This reverts commit 0517081.
This reverts commit 5e1bc09.
This inhibits warnings when the directory to be created already exists.
@mbinna
Copy link
Contributor Author

mbinna commented Feb 9, 2017

Now the pull request is ready to be discussed. Let me know if you are satisfied with the changes.

@ghost ghost requested a review from pmai February 9, 2017 09:37
Copy link
Contributor

@pmai pmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems a very good base case to me.

@mbinna
Copy link
Contributor Author

mbinna commented Feb 9, 2017

Thank you, @pmai. I already discussed with @cmuck about how to get rid of the need to use sudo in Travis. This would reduce the startup time of the Travis build environment a lot. He or I might create a separate pull request.

@ghost ghost merged commit 25698c3 into master Feb 9, 2017
@mbinna mbinna deleted the add-travis-yaml branch February 9, 2017 18:48
@ghost
Copy link

ghost commented Feb 10, 2017

This closes #8

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants