Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Feb 8, 2017

Adds a basic setup.py script such that osi can be installed using:
python setup.py install
Afterwards it is available as python package. I have tested python 2.7 and 3.5 using miniconda on Windows 7, but it should also work on other platforms.
Example:
from osi import osi_common_pb2 as common
common.InterfaceVersion().major
2

I used the short version "osi" as package name (https://www.python.org/dev/peps/pep-0008/#package-and-module-names).

@ghost ghost added the FeatureRequest Proposals which enhance the interface or add additional features. label Feb 8, 2017
@ghost ghost self-assigned this Feb 8, 2017
@ghost ghost requested review from a user and nHirsenkorn February 8, 2017 08:45
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me!

@ghost ghost merged commit a56c22f into master Feb 8, 2017
@mbinna mbinna deleted the add-setup-py branch February 9, 2017 18:48
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FeatureRequest Proposals which enhance the interface or add additional features.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants