Fix python3 relative import issue and setup.py #264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change builds the protobuf files inside the osi3 package path for Python2 to ensure that relative imports work, while not breaking the general cmake build setup. It also moves the protobuf generation to the build command phase for tidiness.
pmai
added
the
Bug
Contributor
Author
|
This should fix issue #243. |
ghost
merged commit 
|
I am working with a module.py which is present in C:\Users\sham\newcarla\carla\PythonClient and have copied all the generated proto_to_python.py in C:\Users\sham\newcarla\carla\PythonClient\proto_generated but there is an import error. i tried running the setup.py in C:\Users\sham\Downloads\open-simulation-interface-master\open-simulation-interface-master and it created a folder osi3 which just has init.py in it. How can i use it as a package for my imports? |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change builds the protobuf files inside the osi3 package path
for Python2 to ensure that relative imports work, while not breaking
the general cmake build setup. It also moves the protobuf generation
to the build command phase for tidiness.